After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753529 - screenshot: Use gnome-screenshot
screenshot: Use gnome-screenshot
Status: RESOLVED FIXED
Product: gnome-flashback
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Flashback Maintainers
GNOME Flashback Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-11 21:13 UTC by Balló György
Modified: 2015-09-13 11:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
libscreenshot: Use gnome-screenshot (2.38 KB, patch)
2015-08-11 21:13 UTC, Balló György
none Details | Review
libscreenshot: Use gnome-screenshot v2 (4.27 KB, patch)
2015-08-12 10:08 UTC, Balló György
none Details | Review

Description Balló György 2015-08-11 21:13:06 UTC
Created attachment 309089 [details] [review]
libscreenshot: Use gnome-screenshot

This makes it functional.

It restores the functionality dropped by this commit:
https://git.gnome.org/browse/gnome-settings-daemon/commit/?id=f33cd1921b4c32eecf54d37d15f9bec0232aa9e3
Comment 1 Balló György 2015-08-12 02:49:10 UTC
I'm working on an improved patch.
Comment 2 Balló György 2015-08-12 10:08:26 UTC
Created attachment 309128 [details] [review]
libscreenshot: Use gnome-screenshot v2

More complete patch. Now it supports filename and include_cursor parameters.
Comment 3 Alberts Muktupāvels 2015-08-12 11:54:18 UTC
Thanks for helping... :)

I will test your patch when I will have free time and most likely I will accept it - this will be 100% better then current warning. :)
Comment 4 Alberts Muktupāvels 2015-08-23 08:14:09 UTC
It sounded too good to be true...

gnome-screenshot first tries to get screenshot from shell (in our case - from gnome-flashback) and fallbacks to X11 if there was problems.

Your code worked (partially) because we never tried to own org.gnome.Shell.Screenshot dbus name that allowed gnome-screenshot directly fallback to X11 as dbus name was not available.

So in short - I think we can not use gnome-screenshot to take screenshots. :(

I pushed few commits. Now we own dbus name, also SelectArea method is implemented.
Comment 5 Alberts Muktupāvels 2015-09-10 18:33:44 UTC
Done! Please test if you have time.
Comment 6 Balló György 2015-09-13 11:40:39 UTC
Thanks! The new code works, but it has a major problem. I opened a new bug: https://bugzilla.gnome.org/show_bug.cgi?id=754952