After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753519 - [review] cleanup singletons and fix some leaked singletons [th/singleton-cleanup-bgo753519]
[review] cleanup singletons and fix some leaked singletons [th/singleton-clea...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-08-11 14:39 UTC by Thomas Haller
Modified: 2015-08-13 08:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2015-08-11 14:39:26 UTC 
Do some cleanup of singletons in NM and make them properly destroy on shutdown.


Note, that when leaving up activated devices on shutdown, we leak some:
  NMActiveConnection
  NMDevice
and thus the singletons:
  NMSessionMonitor
  NMAuthManager
  NMAgentManager


That still needs fixing...
Comment 1 Dan Williams 2015-08-12 21:19:08 UTC 
> agent-monitor: have NMAgentMonitor own NMSessionMonitor instance

s/monitor/manager


the rest looks fine to me