After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753508 - Code cleanups
Code cleanups
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-11 12:57 UTC by Phillip Wood
Modified: 2015-08-17 13:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove SjMetadataMusicbraniz5Private.discid (2.55 KB, patch)
2015-08-11 12:57 UTC, Phillip Wood 		committed Details | Review
Remove ignore_no_media parameter from reread_cd() (4.00 KB, patch)
2015-08-11 12:57 UTC, Phillip Wood 		committed Details | Review
Cleanup metadata_cb() (2.04 KB, patch)
2015-08-11 12:57 UTC, Phillip Wood 		committed Details | Review

Description Phillip Wood 2015-08-11 12:57:43 UTC 
Various code cleanups
Comment 1 Phillip Wood 2015-08-11 12:57:47 UTC 
Created attachment 309064 [details] [review]
Remove SjMetadataMusicbraniz5Private.discid

priv->discid is only used in list_albums() and currently it is leaked if
list_albums() is called more than once.
Comment 2 Phillip Wood 2015-08-11 12:57:52 UTC 
Created attachment 309065 [details] [review]
Remove ignore_no_media parameter from reread_cd()

This wasn't being used consistently, reread_cd() already checks to see
if there is an audio CD in the drive and fails silently if there isn't.
Comment 3 Phillip Wood 2015-08-11 12:57:56 UTC 
Created attachment 309066 [details] [review]
Cleanup metadata_cb()

Use g_clear_pointer() where we can and try to make the logic clearer.
Comment 4 Phillip Wood 2015-08-17 13:12:45 UTC 
Attachment 309064 [details] pushed as 2d924f0 - Remove SjMetadataMusicbraniz5Private.discid
Attachment 309065 [details] pushed as e0159dc - Remove ignore_no_media parameter from reread_cd()
Attachment 309066 [details] pushed as 9daeab5 - Cleanup metadata_cb()