Bug 753502 – NetworkManager-1.0.4: Do not hardcode pkg-config

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 753502 - NetworkManager-1.0.4: Do not hardcode pkg-config


Summary:	NetworkManager-1.0.4: Do not hardcode pkg-config


Status:	RESOLVED FIXED

Product:	NetworkManager
Classification:	Platform
Component:	general
Version:	1.0.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	NetworkManager maintainer(s)
QA Contact:	NetworkManager maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2015-08-11 10:14 UTC by Timo Gurr
Modified:	2015-08-11 11:47 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
0001-configure.ac-Do-not-hardcode-pkg-config.patch (1017 bytes, patch) 2015-08-11 10:14 UTC, Timo Gurr	none	Details \| Review

Description Timo Gurr 2015-08-11 10:14:42 UTC

Created attachment 309054 [details] [review]
0001-configure.ac-Do-not-hardcode-pkg-config.patch

configure.ac already has various pkg-config calls via $PKG_CONFIG, two however are hard-coded and cause issues when compiling with prefixed commands in e.g. cross environments:

GLIB_GENMARSHAL=`pkg-config --variable=glib_genmarshal glib-2.0`
GLIB_MKENUMS=`pkg-config --variable=glib_mkenums glib-2.0`

Attached patch replaces the two offending/remaining pkg-config calls with $PKG_CONFIG.

Comment 1 Thomas Haller 2015-08-11 11:47:15 UTC

merged

master: http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=a6e3a60844aa9e2c4d24afe5b7945e0a6292dd04

nm-1-0: http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=192ad96b1b9e76a219520a76a1a6962a3b12dc90

nm-0-9-10: http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=eb8c2b082a43b59e13be71a87c2768978dd109f5


Thank you for the patch