After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753497 - HEVC videoparser fixes: improve frame start detection
HEVC videoparser fixes: improve frame start detection
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 754010
 
 
Reported: 2015-08-11 09:03 UTC by sreerenj
Modified: 2015-09-10 16:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
videoparsers: h265: Avoid skipping of EOS and EOB nals (1.05 KB, patch)
2015-08-11 09:03 UTC, sreerenj 		committed Details | Review
videoparsers: h265: Avoid skipping of EOS and EOB nals (1.73 KB, patch)
2015-08-11 09:04 UTC, sreerenj 		committed Details | Review

Description sreerenj 2015-08-11 09:03:24 UTC 
Created attachment 309051 [details] [review]
videoparsers: h265: Avoid skipping of EOS and EOB nals

Couple of fixes to hevc videoparser plugin.

-- Avoid skipping of EOS and EOB nalus as broken nals
-- Fix the frame start detection
Comment 1 sreerenj 2015-08-11 09:04:12 UTC 
Created attachment 309052 [details] [review]
videoparsers: h265: Avoid skipping of EOS and EOB nals

Check slice headers in between GST_H265_NAL_SLICE_TRAIL_N
and GST_H265_NAL_SLICE_RASL_R for frame start detection.
Comment 2 Tim-Philipp Müller 2015-08-11 10:35:35 UTC 
Thanks, pushed:

commit a83dabd5e875288be4b7f1b4581aaa0f3f563807
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Tue Aug 11 04:14:19 2015 +0300

    videoparsers: h265: Fix the frame start detection code
    
    Check slice headers in between GST_H265_NAL_SLICE_TRAIL_N
    and GST_H265_NAL_SLICE_RASL_R for frame start detection.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=753497

commit 2775b202dc6a2d396c64d8e9d2b4c2fe000662b0
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Tue Aug 11 03:47:42 2015 +0300

    videoparsers: h265: Avoid skipping of EOS and EOB nals
    
    EndOfSequence and EndOfBitstream nal units have size of 2 bytes.
    Don't consider them as broken nals.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=753497