After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753412 - New Canvas rotation feature rotates brush.
New Canvas rotation feature rotates brush.
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
git master
Other All
: High blocker
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2015-08-09 15:24 UTC by Przemysław Gołąb (n-pigeon)
Modified: 2017-12-22 22:54 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Przemysław Gołąb (n-pigeon) 2015-08-09 15:24:42 UTC
Hi :)

When using Canvas rotation (shift + spacebar) bush rotates with it.
This behaviour is most of the times not wanted, although it could be useful sometimes.

Brush should stay as it is with normal canvas orientation or it should be possible to toggle this behaviour ON/OFF.



I was talking with Mitch about this waaaay back, but for some reason I didn't made bug report sorry...
Comment 1 Michael Natterer 2015-08-10 10:37:00 UTC
Hasn't this already been discussed and agreed upon in another bug?
Comment 2 Michael Natterer 2015-08-10 10:37:45 UTC
ARGH I didn't read your last paragraph :) Consider it on the TODO list...
Comment 3 Michael Natterer 2015-08-20 23:14:02 UTC
This is actually a bug not an enhandement.
Comment 4 Przemysław Gołąb (n-pigeon) 2015-11-14 14:32:18 UTC
This problem also occurs with new Flip Canvas function. Especially problematic when brush dynamics are doing something with rotation, then the direction of rotation is also flipped, hehe ^^'

PS
Wow, HUGE THANK YOU for canvas flipping, it will be supper useful!
Comment 5 Jehan 2017-12-06 23:04:30 UTC
It is not like a deal-breaker, yet since canvas rotation is a new feature, it would be better to have it as well implemented as possible. So make it a potential blocker for 2.10 release.
Comment 6 Ell 2017-12-22 22:54:41 UTC
Fixed in master:

commit eded91e118852434e4647d45b95d7c2ce0eb5053
Author: Ell <ell_se@yahoo.com>
Date:   Fri Dec 22 16:59:13 2017 -0500

    Bug 753412 - New Canvas rotation feature rotates brush.
    
    Replace the "lock brush size to zoom" paint option with a "lock
    brush to view" option, which links the entire brush transform to
    the view transform, so that the brush remains invariant in display
    space under scaling, rotation, and reflection.

 app/core/core-types.h                    |  4 +++-
 app/core/gimpbrush.c                     |  6 +++---
 app/core/gimpcoords-interpolate.c        |  6 ++++--
 app/core/gimpdynamicsoutput.c            | 15 +++++++++++++--
 app/display/gimpdisplayshell-transform.c |  8 ++++++--
 app/paint/gimpbrushcore.c                | 15 +++++++++++++--
 app/paint/gimppaintoptions.c             | 71 ++++++++++++++++++++++++++++++++++++-----------------------------------
 app/paint/gimppaintoptions.h             |  3 ++-
 app/paint/gimpsmudge.c                   |  2 +-
 app/tools/gimppaintoptions-gui.c         |  5 ++---
 10 files changed, 83 insertions(+), 52 deletions(-)