After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753401 - test-suite failure for extension-python
test-suite failure for extension-python
Status: RESOLVED FIXED
Product: libpeas
Classification: Platform
Component: python
1.14.x
Other Linux
: Normal normal
: ---
Assigned To: libpeas-maint
libpeas-maint
Depends on:
Blocks:
 
 
Reported: 2015-08-08 22:44 UTC by Michael Biebl
Modified: 2015-09-22 08:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix Python plugin loader module paths (1.10 KB, patch)
2015-09-01 21:10 UTC, Garrett Regier
committed Details | Review

Description Michael Biebl 2015-08-08 22:44:58 UTC
With 1.14.0 I get the following test-suite failure when running "make check":

TEST: extension-python... (pid=19414)
  /extension/python/garbage-collect:                                   
(/home/michael/git/libpeas/tests/libpeas/.libs/lt-extension-python:19414): libpeas-WARNING **: Error importing plugin 'extension-python':
Traceback (most recent call last):
  • File "/usr/lib/python2.7/importlib/__init__.py", line 37 in import_module
    __import__(name)
  • File "/home/michael/git/libpeas/tests/libpeas/plugins/extension-python/extension-python.py", line 22 in <module>
    import threading
ImportError: No module named threading

(/home/michael/git/libpeas/tests/libpeas/.libs/lt-extension-python:19414): libpeas-WARNING **: Error loading plugin 'extension-python'
**
libpeas:ERROR:testing-extension.c:74:test_runner: assertion failed: (peas_engine_load_plugin (fixture->engine, fixture->info))
FAIL
GTester: last random seed: R02Sad3afad80b854441d237cc83d3ec88e8
/bin/bash: line 1: 19343 Terminated              G_SLICE=debug-blocks gtester --verbose engine extension-c extension-set plugin-info extension-python extension-python3
Makefile:974: recipe for target 'test' failed
make[4]: *** [test] Error 143
make[4]: Leaving directory '/home/michael/git/libpeas/tests/libpeas'
Makefile:726: recipe for target 'test' failed
make[3]: *** [test] Error 1
make[3]: Leaving directory '/home/michael/git/libpeas/tests'
Makefile:604: recipe for target 'check-am' failed
make[2]: *** [check-am] Error 2
make[2]: Leaving directory '/home/michael/git/libpeas/tests'
Makefile:456: recipe for target 'check-recursive' failed
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory '/home/michael/git/libpeas/tests'
Makefile:499: recipe for target 'check-recursive' failed
make: *** [check-recursive] Error 1



git bisect says this is the first faulty commit:

commit 83a44f3c0e610814923a29c419b4a1ba16fbee08
Author: Garrett Regier <garrettregier@gmail.com>
Date:   Mon Jan 5 07:39:33 2015 -0800

    Use Python to implement the plugin loader's logic
    
    This allows us to avoid the CPython API and have a
    more understandable implementation.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=742349
Comment 1 Garrett Regier 2015-09-01 21:10:50 UTC
Created attachment 310449 [details] [review]
Fix Python plugin loader module paths

Popping the first item from the module paths was only required when PySys_SetArgv() was used.
Comment 2 Garrett Regier 2015-09-22 08:10:10 UTC
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.