GNOME Bugzilla – Bug 753385
media: Adding multiple dynamic payload is broken
Last modified: 2015-08-16 13:37:02 UTC
This is not working, and seems to be broken due to multiple reason. Here's a first patch to progressively address it.
Created attachment 308940 [details] [review] media: Only add fakesink once per pipeline The intention is to prevent going PLAYING state before pads are created. If there was mutilple dynamic payload, it would leak few fakesink and actually prevent from ever reaching playing state.
Created attachment 308950 [details] [review] media-test: Test for multiple dynamic payload
Actually, I wrote this test and didn't hit any other issue, maybe Francisco test was broken. This fixes the issue, and works if no dynpay is being used (unlike the reverted patch).
Attachment 308940 [details] pushed as 707ac9c - media: Only add fakesink once per pipeline Attachment 308950 [details] pushed as 3667e71 - media-test: Test for multiple dynamic payload
Created attachment 309196 [details] [review] Removing unnecessary assertion test_media_multidyn_prepare works fine in my installation as well. Thank you, Nicolas.
Review of attachment 309196 [details] [review]: ::: tests/check/gst/media.c @@ -470,3 @@ fail_unless (gst_rtsp_media_n_streams (media) == 0); - fail_unless (gst_rtsp_media_n_streams (media) == 0); I agree, I notice when copying form the other test (where I think it's also useless. Can you update, thanks for spotting.
Review of attachment 309196 [details] [review]: commit 418e1fe09001f9a4defc291d9af221d598d9cf45 Author: Francisco Velazquez <francisv@ifi.uio.no> Date: Thu Aug 13 11:24:10 2015 +0200 media-test: Removing unnecessary assertion https://bugzilla.gnome.org/show_bug.cgi?id=753385