After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753375 - ggit_clone_options_free breaks compilation
ggit_clone_options_free breaks compilation
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-08 04:22 UTC by Mohan R
Modified: 2015-08-11 07:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to src/dialogs/gb-new-project-dialog.c (796 bytes, patch)
2015-08-08 04:22 UTC, Mohan R
none Details | Review

Description Mohan R 2015-08-08 04:22:33 UTC
Created attachment 308931 [details] [review]
patch to src/dialogs/gb-new-project-dialog.c

ggit_clone_options_free is no more available in libgit2-glib. patch attached to use g_object_unref.
Comment 1 Christian Hergert 2015-08-08 05:44:31 UTC
Did libgit2-glib also bump a version number? If we don't ensure a new libgit2-glib is used, people will have crashes anyway.
Comment 2 Mohan R 2015-08-08 06:01:04 UTC
yes, they bumped version from v0.23.2 to v0.23.4. diff shows ggit_clone_options_free removed.
Comment 3 Christian Hergert 2015-08-11 07:58:00 UTC
FetchOptions had not changed to an object. I pushed this patch with a few changes including the fetch options and a configure.ac bump for libgit2-glib.

commit 870b2d2c41328092447540d4aae52c12ac1e1fcc