After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753356 - window-slot should handle the window visibility
window-slot should handle the window visibility
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Tabs
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-07 14:47 UTC by Georges Basile Stavracas Neto
Modified: 2015-08-07 18:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window-slot: show window when view starts loading (3.65 KB, patch)
2015-08-07 14:47 UTC, Georges Basile Stavracas Neto 		committed Details | Review

Description Georges Basile Stavracas Neto 2015-08-07 14:47:27 UTC 
Currently, NautilusView contacts NautilusWindow directly for
it to show the current view. Since we're isolating NautilusView,
it is a good idea to not do it.
Comment 1 Georges Basile Stavracas Neto 2015-08-07 14:47:31 UTC 
Created attachment 308903 [details] [review]
window-slot: show window when view starts loading

NautilusView directly access NautilusWindow to make sure
the window is shown when the view starts loading, and not
before this.

Since we're restricting communication between NautilusView
and other widgets, the view shouldn't ask the window directly.

Fixed by making NautilusWindowSlot handle the visibility of the
window on NautilusView::begin-loading signal.
Comment 2 Carlos Soriano 2015-08-07 16:12:24 UTC 
Review of attachment 308903 [details] [review]:

So I think what we actually want is show the window inmediatily, and then mark the view as loading, how does that it sounds?
It is actually part of the wanted design, not sure if I understood correctly the code since Im on the phone :)
Comment 3 Carlos Soriano 2015-08-07 16:32:01 UTC 
Review of attachment 308903 [details] [review]:

Ok so to not spend time on this... I would say this looks okay. Update the commit message to explain why you can remove the code that updates the title of suposedly every hidding slot that wxisted before showing the window
Comment 4 Georges Basile Stavracas Neto 2015-08-07 18:32:01 UTC 
Attachment 308903 [details] pushed as ae96063 - window-slot: show window when view starts loading