GNOME Bugzilla – Bug 753348
gtkdocize does not handle -flat flavours
Last modified: 2016-03-24 08:31:26 UTC
The *-flat flavours were added in the switch statement in 4413765e4dd6f6474651f1b2044aa9016b832e7c but in the wrong order so generic flavours are always picked-up first.
Created attachment 308882 [details] [review] Patch to reorder the switch statement
The following fix has been pushed: 391b9f1 gtkdocize: Fix flavour matching order
Created attachment 309350 [details] [review] gtkdocize: Fix flavour matching order *-flat versions were ignored because the generic flavour was picked first in the switch Fixes #753348 Signed-off-by: Quentin Glidic <sardemff7+git@sardemff7.net>
Thanks!
Apparently this change broke some packages, like kmod: https://bugs.debian.org/819089 The problem is that -flat version have s/EXTRA_DIST =/EXTRA_DIST +=/, however EXTRA_DIST may not always be already defined (like is the case for kmod). Do you think this is something that can be fixed here, or this is a problem with packages in question?
If packages were asking for the -flat version and got the regular one, they should have noticed this bug (this one, not the kmod one) and fixed it. If they didn’t, then they were using the regular version of the file and should continue to use it by fixing their call.