After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753348 - gtkdocize does not handle -flat flavours
gtkdocize does not handle -flat flavours
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
unspecified
Other Linux
: Normal major
: 1.25
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-07 08:43 UTC by Quentin "Sardem FF7" Glidic
Modified: 2016-03-24 08:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to reorder the switch statement (1004 bytes, patch)
2015-08-07 08:44 UTC, Quentin "Sardem FF7" Glidic
committed Details | Review
gtkdocize: Fix flavour matching order (1015 bytes, patch)
2015-08-16 09:44 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
committed Details | Review

Description Quentin "Sardem FF7" Glidic 2015-08-07 08:43:55 UTC
The *-flat flavours were added in the switch statement in 4413765e4dd6f6474651f1b2044aa9016b832e7c but in the wrong order so generic flavours are always picked-up first.
Comment 1 Quentin "Sardem FF7" Glidic 2015-08-07 08:44:47 UTC
Created attachment 308882 [details] [review]
Patch to reorder the switch statement
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2015-08-16 09:44:25 UTC
The following fix has been pushed:
391b9f1 gtkdocize: Fix flavour matching order
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2015-08-16 09:44:33 UTC
Created attachment 309350 [details] [review]
gtkdocize: Fix flavour matching order

*-flat versions were ignored because the generic flavour was picked first in the switch

Fixes #753348

Signed-off-by: Quentin Glidic <sardemff7+git@sardemff7.net>
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2015-08-16 09:45:09 UTC
Thanks!
Comment 5 Dmitry Shachnev 2016-03-23 23:16:06 UTC
Apparently this change broke some packages, like kmod: https://bugs.debian.org/819089

The problem is that -flat version have s/EXTRA_DIST =/EXTRA_DIST +=/, however EXTRA_DIST may not always be already defined (like is the case for kmod).

Do you think this is something that can be fixed here, or this is a problem with packages in question?
Comment 6 Quentin "Sardem FF7" Glidic 2016-03-24 08:31:26 UTC
If packages were asking for the -flat version and got the regular one, they should have noticed this bug (this one, not the kmod one) and fixed it.
If they didn’t, then they were using the regular version of the file and should continue to use it by fixing their call.