GNOME Bugzilla – Bug 753325
rtpklv(de)pay: add "RTP" in the klass string
Last modified: 2015-08-16 13:39:58 UTC
Created attachment 308859 [details] [review] rtpklv(de)pay: add "RTP" in the klass string GstRTSPMedia uses this classification to detect the real payloader inside a dynpay bin and asserts if it doesn't find it, therefore it is required. rtsp-media.c:2276: if (strstr (klass, "Payloader") && strstr (klass, "RTP")) {
Review of attachment 308859 [details] [review]: Make sense to me.
How did you manage to break the ü in Tim's name in the patch? :) Looks like a broken git config or something. commit 2e590a32eb88da2e200e6180747de76ccbd7797c Author: George Kiagiadakis <george.kiagiadakis@collabora.com> Date: Thu Aug 6 17:46:13 2015 +0200 rtpklv(de)pay: add "RTP" in the klass string GstRTSPMedia uses this classification to detect the real payloader inside a dynpay bin and asserts if it doesn't find it, therefore it is required https://bugzilla.gnome.org/show_bug.cgi?id=753325
(In reply to Sebastian Dröge (slomo) from comment #2) > How did you manage to break the ü in Tim's name in the patch? :) Looks like > a broken git config or something. > Heh! :) No, it's a browser issue. The patch is correct on my file system and it is also shown correctly if go to patch review, but if you try to download it as plain text, the browser interprets it as Western encoding instead of Unicode. Just switch the browser's encoding manually.