After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753315 - ignores gtk-application-prefer-dark_theme
ignores gtk-application-prefer-dark_theme
Status: RESOLVED FIXED
Product: gaupol
Classification: Other
Component: general
0.28.2
Other Linux
: Normal minor
: ---
Assigned To: gaupol-maint@gnome.bugs
gaupol-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2015-08-06 13:04 UTC by ozarow+bugzilla.gnome.org
Modified: 2015-08-06 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description ozarow+bugzilla.gnome.org 2015-08-06 13:04:09 UTC
$ grep gtk-application-prefer-dark-theme ~/.config/gtk-3.0/settings.ini
gtk-application-prefer-dark-theme = true

$ grep dark_theme ~/.config/gaupol/gaupol.conf
# dark_theme = true

and gaupol starts in light theme anyway.

Uncommenting dark_theme in gaupol.conf does what I want, but if this config value is not explicitly set in gaupol.conf I'd expect it to honour global GTK settings rather than defaulting to light theme.
See gaupol/main.py:60


Thanks for writing Gaupol, BTW :)
Comment 1 Osmo Salomaa 2015-08-06 14:02:20 UTC
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.

commit 0fa8c5b3d4b0082deddae20aa2e8c4a7a2efa4ef
Author: Osmo Salomaa <otsaloma@iki.fi>
Date:   Thu Aug 6 16:48:57 2015 +0300

    Only force theme variant if dark_theme is true.
    
    If gaupol.conf.general.dark_theme is false (the default), nothing is
    done, thus allowing theming to fall back to global settings.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=753315

https://github.com/otsaloma/gaupol/commit/0fa8c5b3d4b0082deddae20aa2e8c4a7a2efa4ef

Related to dark themes, it seems that 'GTK_THEME=Adwaita:dark gaupol' works for widgets, but not the window titlebar. I'll look into that when I begin migrating Gaupol away from deprecated GTK2 stuff -- GtkApplication and Gtk.Window.set_titlebar etc. might affect that.