GNOME Bugzilla – Bug 753314
No external subtitles for Panasonic again
Last modified: 2015-08-09 11:33:46 UTC
Created attachment 308847 [details] Difference in response between v0.24.2 and v0.26.1 External subtitles has been added for Panasonic, see: https://bugzilla.gnome.org/show_bug.cgi?id=661228#c13 However: Somewhere between v0.24.2 (Fedora 21) and v0.26.1 (Fedora 22) subtitles stopped working on my Panasonic TX-P50GT60. I captured the difference between the versions, the most obvious differences: The "pv:subtitleFileType" and "pv:subtitleFileUri" attributes are missing from the first res element. 24: <res size="3132991716" protocolInfo="http-get:*:video/mp4:DLNA.ORG_OP=01" pv:subtitleFileType="SRT" pv:subtitleFileUri="http://192.168.1.171:34239/MediaExport/i/(...)/sub/0.srt">http://192.168.1.171:34239/MediaExport/i/(...).mp4</res> 26: <res size="3132991716" protocolInfo="http-get:*:video/mp4:DLNA.ORG_OP=01">http://192.168.1.171:52468/MediaExport/i/(...)/res/primary_http.mp4</res> The other "pv:subtitleFileUri" attributes seem to have an invalid uri (file:///... instead of http://...) 24: <res protocolInfo="http-get:*:video/mpeg:DLNA.ORG_PN=MPEG_TS_SD_EU_ISO;DLNA.ORG_CI=1;DLNA.ORG_FLAGS=01700000000000000000000000000000" resolution="720x576" pv:subtitleFileType="SRT" pv:subtitleFileUri="http://192.168.1.171:34239/MediaExport/i/(...)/sub/0.srt">http://192.168.1.171:34239/MediaExport/i/(...)/tr/MPEG_TS_SD_EU_ISO.mpg</res> 26: <res resolution="720x576" protocolInfo="http-get:*:video/mpeg:DLNA.ORG_PN=MPEG_TS_SD_EU_ISO;DLNA.ORG_OP=10;DLNA.ORG_CI=1;DLNA.ORG_FLAGS=01700000000000000000000000000000" pv:subtitleFileType="SRT" pv:subtitleFileUri="file:///home/jan/Videos/wds04/Whatever.srt">http://192.168.1.171:52468/MediaExport/i/(...)/res/MPEG_TS_SD_EU_ISO.mpg</res>
Uch. ouch. How could I miss that. Sorry about that
Created attachment 308933 [details] [review] server: Fix rewriting of subtitle uris in pv tags Signed-off-by: Jens Georg <mail@jensge.org>
Missing subtitle on first resource is due to bug 753382
Created attachment 308972 [details] [review] server: Add PV subtitle to all resources Work-around issue with resources without DLNA profile losing its dlna_flags. Signed-off-by: Jens Georg <mail@jensge.org>
Attachment 308933 [details] pushed as 542e5d2 - server: Fix rewriting of subtitle uris in pv tags Attachment 308972 [details] pushed as eede589 - server: Add PV subtitle to all resources