After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753305 - Should be able to scroll calendar
Should be able to scroll calendar
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: calendar
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 780959 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-08-06 03:55 UTC by Cosimo Cecchi
Modified: 2017-11-24 18:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (331.01 KB, image/png)
2015-08-06 03:55 UTC, Cosimo Cecchi 		  Details
panelMenu: consider scale factor when setting max-height (1.81 KB, patch)
2017-04-07 01:32 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2015-08-06 03:55:50 UTC 
Created attachment 308829 [details]
screenshot

The calendar popup does not seem to scroll when there are a lot of events. See screenshot.
Comment 1 Florian Müllner 2016-07-07 23:43:32 UTC 
Have you seen this again? The list is scrollable, and I haven't been able to reproduce this issue, so no idea off-hand what's going on there ...
Comment 2 Florian Müllner 2017-04-06 07:18:45 UTC 
*** Bug 780959 has been marked as a duplicate of this bug. ***
Comment 3 Florian Müllner 2017-04-06 07:21:49 UTC 
Was this original report on a hiDpi system as well? I suspect that we need to consider the scaling in https://git.gnome.org//browse/gnome-shell/tree/js/ui/panelMenu.js#n173, but don't have a system to test and confirm ...
Comment 4 Cosimo Cecchi 2017-04-07 01:32:15 UTC 
Created attachment 349426 [details] [review]
panelMenu: consider scale factor when setting max-height

Since the workarea and margins are both in pysical pixels dimensions (we
fetch margins from Clutter, not from the theme), but the CSS expects
logical (scaled) pixels, unless we consider the scale factor when
setting max-height, it won't work on a HiDpi display.

This fixes missing scrollbars when the calendar popup is full on HiDpi
displays.
Comment 5 Cosimo Cecchi 2017-04-07 01:33:15 UTC 
Oops I forgot I had already reported this!
Indeed my original report was on the same machine with a HiDpi screen. Here's a patch that I have tested to fix the issue.
Comment 6 Florian Müllner 2017-04-07 01:43:42 UTC 
Review of attachment 349426 [details] [review]:

LGTM
Comment 7 Cosimo Cecchi 2017-04-07 01:59:57 UTC 
Thanks for the quick review, pushed.

Attachment 349426 [details] pushed as cad5e06 - panelMenu: consider scale factor when setting max-height
Comment 8 Florian Müllner 2017-11-24 18:02:57 UTC 
*** Bug 774143 has been marked as a duplicate of this bug. ***