GNOME Bugzilla – Bug 753267
[PATCH] Drop telepathy integration and presence API support
Last modified: 2015-08-05 20:55:31 UTC
Created attachment 308761 [details] [review] Drop telepathy integration and presence API support It's broken and not really useful in the current form. Note that the telepathy integration was dropped from GNOME Shell's User menu too: https://git.gnome.org/browse/gnome-shell/commit/?id=d802416daeb2f9bfd25132e6465ccf022074c5b9
Review of attachment 308761 [details] [review]: ::: gnome-panel/libpanel-util/panel-session-manager.c @@ +31,1 @@ GDBusProxy *presence_proxy; presence_proxy should be removed from priv struct too.
(In reply to György Balló from comment #0) > It's broken and not really useful in the current form. How it is broken? How it was supposed to work? I have never used it...
Created attachment 308793 [details] [review] Drop telepathy integration and presence API support v2 Attached an updated patch. We discussed it earlier on the mailing list: https://mail.gnome.org/archives/gnome-flashback-list/2014-October/msg00067.html It was originally a toggle menu, but currently you can toggle both options, because the panel won't get back the actual presence state from gnome-session. Anyway, I don't think that it's a useful feature, already dropped from GNOME Shell, so I think we could drop this feature too.
Ok, lets drop it... Please add this bug url to commit message. Anyway we need to speak to empathy devs: https://git.gnome.org/browse/empathy/tree/src/empathy.c#n228 We need that self->shell_running is not set to TRUE if gnome-flashback is running... If shell is detected then extra loop to check for org.gnome.Flashback could be added and if found shell_running could be set back to FALSE. Maybe this could be opened as new bug against gnome-flashback so I don't forget about this?
Created attachment 308817 [details] [review] Drop telepathy integration and presence API support v3 > We need that self->shell_running is not set to TRUE if gnome-flashback is running... Yes it's a different problem. Another bug needs to be filled.