GNOME Bugzilla – Bug 753190
Support <cmakeargs> tag for cmake module and fix webkit build without wayland
Last modified: 2015-08-10 07:51:30 UTC
Commit 869e16b tried to make X11 and Wayland dependencies optional in WebKit, but it doesn't work because only autotools module supports conditionally adding autogenargs.
I will upload patches to add conditional cmakeargs support for cmake module and fix WebKit build without Wayland.
Created attachment 308687 [details] [review]
Add a missing comma
This patch is not directly related to the problem, but it was found during
fixing this bug ...
Created attachment 308688 [details] [review]
cmake: collect args from cmakeargs and makeargs tags
This patch reuses collect_args function from autotools.py. Do you think it is
acceptable to import autotools.py code from cmake.py? Or we should move the
function to __init__.py?
Created attachment 308689 [details] [review]
core-deps: Use cmakeargs instead of autogenargs in WebKit
This makes what commit 869e16b wants to do work.
Thanks, go and push it.
Attachment 308687 [details] pushed as 67d61e4 - Add a missing comma
Attachment 308688 [details] pushed as ae68cb8 - cmake: collect args from cmakeargs and makeargs tags
Attachment 308689 [details] pushed as 8eb8008 - core-deps: Use cmakeargs instead of autogenargs in WebKit