After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753156 - mutter git branch gnome-3-16 fails to build.
mutter git branch gnome-3-16 fails to build.
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2015-08-02 20:00 UTC by Hussam Al-Tayeb
Modified: 2015-08-03 09:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Revert "backend-x11: Fix our awful hack for crossing events, too" (1.58 KB, patch)
2015-08-02 20:09 UTC, Florian Müllner
committed Details | Review

Description Hussam Al-Tayeb 2015-08-02 20:00:13 UTC
Hello. This commit https://git.gnome.org/browse/mutter/commit/?h=gnome-3-16&id=55fd05ea588a34564128f9f657084c82eae1cb0b
braks compiling mutter from gnome-3-16 branch.


configure flags are:

./configure --prefix=/usr --sysconfdir=/etc \
      --libexecdir=/usr/lib/mutter \
      --localstatedir=/var --disable-static \
      --disable-schemas-compile --enable-compile-warnings=minimum --disable-wayland

Note: I have to disable wayland otherwise gnome-shell refuses to even start which is fine since nvidia wayland support is going to long take years.


Anyway, error is:

In file included from /usr/lib/glib-2.0/include/glibconfig.h:9:0,
                 from /usr/include/glib-2.0/glib/gtypes.h:32,
                 from /usr/include/glib-2.0/glib/galloca.h:32,
                 from /usr/include/glib-2.0/glib.h:30,
                 from /usr/include/glib-2.0/gobject/gbinding.h:28,
                 from /usr/include/glib-2.0/glib-object.h:23,
                 from ./backends/meta-backend-private.h:29,
                 from backends/x11/meta-backend-x11.h:28,
                 from backends/x11/meta-backend-x11.c:30:
backends/x11/meta-backend-x11.c: In function ‘translate_crossing_event’:
backends/x11/meta-backend-x11.c:150:21: error: ‘MetaBackendX11Private {aka struct _MetaBackendX11Private}’ has no member named ‘mode’
       g_assert (priv->mode == META_BACKEND_X11_MODE_COMPOSITOR);
                     ^
/usr/include/glib-2.0/glib/gmacros.h:319:8: note: in definition of macro ‘_G_BOOLEAN_EXPR’
    if (expr)                                    \
        ^
/usr/include/glib-2.0/glib/gtestutils.h:106:49: note: in expansion of macro ‘G_LIKELY’
                                              if G_LIKELY (expr) ; else \
                                                 ^
backends/x11/meta-backend-x11.c:150:7: note: in expansion of macro ‘g_assert’
       g_assert (priv->mode == META_BACKEND_X11_MODE_COMPOSITOR);
       ^
backends/x11/meta-backend-x11.c:150:31: error: ‘META_BACKEND_X11_MODE_COMPOSITOR’ undeclared (first use in this function)
       g_assert (priv->mode == META_BACKEND_X11_MODE_COMPOSITOR);
                               ^
/usr/include/glib-2.0/glib/gmacros.h:319:8: note: in definition of macro ‘_G_BOOLEAN_EXPR’
    if (expr)                                    \
        ^
/usr/include/glib-2.0/glib/gtestutils.h:106:49: note: in expansion of macro ‘G_LIKELY’
                                              if G_LIKELY (expr) ; else \
                                                 ^
backends/x11/meta-backend-x11.c:150:7: note: in expansion of macro ‘g_assert’
       g_assert (priv->mode == META_BACKEND_X11_MODE_COMPOSITOR);
       ^
backends/x11/meta-backend-x11.c:150:31: note: each undeclared identifier is reported only once for each function it appears in
       g_assert (priv->mode == META_BACKEND_X11_MODE_COMPOSITOR);
                               ^
/usr/include/glib-2.0/glib/gmacros.h:319:8: note: in definition of macro ‘_G_BOOLEAN_EXPR’
    if (expr)                                    \
        ^
/usr/include/glib-2.0/glib/gtestutils.h:106:49: note: in expansion of macro ‘G_LIKELY’
                                              if G_LIKELY (expr) ; else \
                                                 ^
backends/x11/meta-backend-x11.c:150:7: note: in expansion of macro ‘g_assert’
       g_assert (priv->mode == META_BACKEND_X11_MODE_COMPOSITOR);
       ^
Makefile:1681: recipe for target 'backends/x11/meta-backend-x11.lo' failed
make[4]: *** [backends/x11/meta-backend-x11.lo] Error 1
make[4]: Leaving directory '/home/hussam/src/packages/mutter/trunk/src/mutter/src'
Makefile:1856: recipe for target 'all-recursive' failed
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory '/home/hussam/src/packages/mutter/trunk/src/mutter/src'
Makefile:1030: recipe for target 'all' failed
make[2]: *** [all] Error 2
make[2]: Leaving directory '/home/hussam/src/packages/mutter/trunk/src/mutter/src'
Makefile:481: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
Comment 1 Florian Müllner 2015-08-02 20:09:27 UTC
The following fix has been pushed:
f4d9153 Revert "backend-x11: Fix our awful hack for crossing events, too"

Sorry for that - some user was bugging me about applying that patch on the 3.16 branch, and I didn't even compile-test :-(
Comment 2 Florian Müllner 2015-08-02 20:09:37 UTC
Created attachment 308637 [details] [review]
Revert "backend-x11: Fix our awful hack for crossing events, too"

This reverts commit 55fd05ea588a34564128f9f657084c82eae1cb0b.
Comment 3 Hussam Al-Tayeb 2015-08-02 20:23:49 UTC
Thank you for taking care of this quickly :)
Comment 4 Hussam Al-Tayeb 2015-08-03 09:17:17 UTC
The updated patch is making my computer freeze on resuming from hibernate.
Going back to 3.16.3 release fixes it.