After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753153 - No timeout when password is wrong
No timeout when password is wrong
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-08-02 17:26 UTC by Alexandre Franke
Modified: 2017-09-12 09:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vnc-display: Request new credentials after failed auth (1.14 KB, patch)
2016-09-01 13:00 UTC, Visarion Alexandru 		none Details | Review
vnc-display: Request new credentials after failed auth (1.07 KB, patch)
2017-08-24 14:18 UTC, Felipe Borges 		committed Details | Review

Description Alexandre Franke 2015-08-02 17:26:11 UTC 
I'm trying to login to a password protected VNC connection. If I type the wrong password, it just seems to load forever and doesn't tell me that the password is wrong.
Comment 1 Alexandre Franke 2015-08-02 17:27:32 UTC 
Vinagre immediately throws an error by the way.
Comment 2 Visarion Alexandru 2016-09-01 13:00:16 UTC 
Created attachment 334602 [details] [review]
vnc-display: Request new credentials after failed auth

Currently, if the user attempts to authenticate and fails,
we don't request credentials again, which results in the
display appearing as connecting endlessly.

Let's fix this by requesting different credentials whenever
we find out that the previous ones weren't valid.
Comment 3 Felipe Borges 2017-08-24 14:18:41 UTC 
Created attachment 358347 [details] [review]
vnc-display: Request new credentials after failed auth

Currently, if the user attempts to authenticate and fails,
we don't request credentials again, which results in the
display appearing as connecting endlessly.

Let's fix this by requesting different credentials whenever
we find out that the previous ones weren't valid.
Comment 4 Felipe Borges 2017-08-24 14:19:37 UTC 
Review of attachment 358347 [details] [review]:

Sure! Thanks for the patch. I made a small update to your commit, but it is essentially the same.

Please hold until the next development phase to push it.
Comment 5 Felipe Borges 2017-09-12 09:18:01 UTC 
Attachment 358347 [details] pushed as 69da6b0 - vnc-display: Request new credentials after failed auth