After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753145 - gtkdoc-mkhtml fails on spaces in file names
gtkdoc-mkhtml fails on spaces in file names
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
1.24
Other Linux
: Normal normal
: 1.25
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-01 20:48 UTC by Jussi Pakkanen
Modified: 2016-09-28 21:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
mkhtml: quote document to allow spaces in filenames (875 bytes, patch)
2015-08-01 21:13 UTC, Igor Gnatenko
none Details | Review
mkhtml/pdf: Pass searchpath as quoted to allow spaces in the names (2.30 KB, patch)
2016-09-28 11:34 UTC, Thibault Saunier
none Details | Review

Description Jussi Pakkanen 2015-08-01 20:48:43 UTC
If you have an sgml file in a path with a space in it, it fails. For example:

gtkdoc-mkhtml foobar '../../test cases/frameworks/10 gtk-doc/doc/foobar-docs.sgml'

Outputs

head: cannot open ‘../../test’ for reading: No such file or directory
head: cannot open ‘cases/frameworks/10’ for reading: No such file or directory
head: cannot open ‘gtk-doc/doc/foobar-docs.sgml’ for reading: No such file or directory

If the file is in a directory without spaces, then it will work.
Comment 1 Igor Gnatenko 2015-08-01 21:13:49 UTC
Created attachment 308624 [details] [review]
mkhtml: quote document to allow spaces in filenames

Reference: https://bugzilla.gnome.org/show_bug.cgi?id=753145
Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>
Comment 2 Igor Gnatenko 2015-08-01 21:14:12 UTC
Please note that I have not tested patch yet.
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2015-08-16 10:01:38 UTC
Thanks for the patch! It is correct. I've expanded your patch to also fix gtkdoc-mkpdf and cover a few more cases.

commit 12adab6b0a28aec4008c6deed247bf944b5882f2
Author: Igor Gnatenko <ignatenko@src.gnome.org>
Date:   Sun Aug 2 00:13:20 2015 +0300

    mkhtml/pdf: quote document to allow spaces in filenames
    
    Reference: https://bugzilla.gnome.org/show_bug.cgi?id=753145
    Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>
Comment 4 Thibault Saunier 2016-09-28 11:33:58 UTC
This fix is not enough, in gtkdoc-mkhtml passing $path_arg (which is set to "--path $searchpath") still makes the searchpath separated strings in xsltproc list of arguments.
Comment 5 Thibault Saunier 2016-09-28 11:34:01 UTC
Created attachment 336429 [details] [review]
mkhtml/pdf: Pass searchpath as quoted to allow spaces in the names
Comment 6 Nirbheek Chauhan 2016-09-28 20:59:08 UTC
I already have a patch for this in https://bugzilla.gnome.org/show_bug.cgi?id=769125 that fixes all instances of spaces.
Comment 7 Nirbheek Chauhan 2016-09-28 21:11:01 UTC
I'm going to close this bug because the original issue it was about has been fixed. Let's talk on the new one. :)