GNOME Bugzilla – Bug 753138
wayland: Invalidate our gtk_surface when we're unmapped
Last modified: 2015-08-03 12:31:26 UTC
This should make modal dialogs actually be modal
Created attachment 308608 [details] [review] wayland: Invalidate our gtk_surface when we're unmapped Otherwise if we get mapped again we'll try to use an invalid gtk_surface and the compositor will disconnect us.
Created attachment 308609 [details] [review] wayland: Ensure modal hint gets set on map We need to be mapped to have a gtk_surface and thus be able to do requests on it so we need to save the modal hint and apply it when we get mapped so that code that sets the hint before showing a window doesn't get ignored.
Review of attachment 308608 [details] [review]: ::: gdk/wayland/gdkwindow-wayland.c @@ +1351,2 @@ } Don't we have to call something like gtk_surface_destroy here ?
Review of attachment 308609 [details] [review]: sure
Created attachment 308662 [details] [review] wayland: Invalidate our gtk_surface when we're unmapped -- (In reply to Matthias Clasen from comment #3) > Don't we have to call something like gtk_surface_destroy here ? Yes, of course.
Review of attachment 308662 [details] [review]: looks good to me
Attachment 308609 [details] pushed as bd3b496 - wayland: Ensure modal hint gets set on map Attachment 308662 [details] pushed as 3626307 - wayland: Invalidate our gtk_surface when we're unmapped