After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753121 - gtkmm requires C++11, but gnome-system-monitor still sets -std=c++98 in configure.ac
gtkmm requires C++11, but gnome-system-monitor still sets -std=c++98 in confi...
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-01 05:51 UTC by Ting-Wei Lan
Modified: 2015-08-02 04:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Replace -std=c++98 with -std=c++11 (742 bytes, patch)
2015-08-01 05:53 UTC, Ting-Wei Lan
committed Details | Review

Description Ting-Wei Lan 2015-08-01 05:51:59 UTC
Recent updates in gtkmm cause it to require C++11, so -std=c++98 set in gnome-system-monitor causes build failure. Replacing -std=c++98 with -std=c++11 can resolve the problem.
Comment 1 Ting-Wei Lan 2015-08-01 05:53:28 UTC
Created attachment 308596 [details] [review]
build: Replace -std=c++98 with -std=c++11

Gtkmm requires C++11 now.
Comment 2 Robert Roth 2015-08-01 07:40:23 UTC
Review of attachment 308596 [details] [review]:

Thanks, looks fine, feel free to push.
Comment 3 Ting-Wei Lan 2015-08-01 08:17:08 UTC
Attachment 308596 [details] pushed as e5d3ac0 - build: Replace -std=c++98 with -std=c++11
Comment 4 Benoît Dejean 2015-08-01 13:53:13 UTC
We may just the drop the -std and let the compiler do what it wants.
Back then, I added that to ensure compatibility with gcc-2.9x.
Let's drop it.
Comment 5 Ting-Wei Lan 2015-08-01 14:28:54 UTC
We cannot drop it because some compilers use C++98 as the default standard version.
Comment 6 Benoît Dejean 2015-08-02 04:44:49 UTC
Then let's do it smartly like Murray : https://git.gnome.org/browse/gnome-system-monitor/commit/?id=d81fe60bc3d6a481b6bc330490fd079b5cc30acc