After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753093 - Implement shared-secondary-process model as WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES with a web process limit of 1
Implement shared-secondary-process model as WEBKIT_PROCESS_MODEL_MULTIPLE_SEC...
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-31 08:12 UTC by Carlos Garcia Campos
Modified: 2015-08-23 00:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Implement shared-secondary-process model as MULTIPLE_SECONDARY_PROCESSES with a process limit of 1 (2.10 KB, patch)
2015-07-31 08:18 UTC, Carlos Garcia Campos
committed Details | Review
buildlog with 3.16 latest git (1.38 KB, text/plain)
2015-08-22 22:26 UTC, Hirotaka Maruyama
  Details

Description Carlos Garcia Campos 2015-07-31 08:12:36 UTC
Now that webkit has API to set a limit to the amount of web process created in WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES model, we make our shared-secondary-process model use the multiple web processes WebKit model but with a limit of 1 web process. So, in the end the main difference would be that the networking would be done in the network process, instead of the web process, with all the advantages that has. For example, we will always use the new disk cache, instead of the soup one.
Comment 1 Carlos Garcia Campos 2015-07-31 08:18:08 UTC
Created attachment 308518 [details] [review]
Implement shared-secondary-process model as  MULTIPLE_SECONDARY_PROCESSES with a process limit of 1
Comment 2 Michael Catanzaro 2015-07-31 12:54:33 UTC
Looks good.
Comment 3 Carlos Garcia Campos 2015-08-03 09:00:38 UTC
Comment on attachment 308518 [details] [review]
Implement shared-secondary-process model as  MULTIPLE_SECONDARY_PROCESSES with a process limit of 1

Pushed to git master
Comment 4 Hirotaka Maruyama 2015-08-22 22:26:01 UTC
Created attachment 309872 [details]
buildlog with 3.16 latest git

Hi devs,

This patch seems to fail to build with the latest 3.16 git codebase?

Or anythong wrong with me? Full buildlog of my launchpad PPA is here: https://launchpadlibrarian.net/215316377/buildlog_ubuntu-wily-i386.epiphany-browser_3.16.3%2Bgit20150803-0ubuntu2~wily1_BUILDING.txt.gz

Best Regards.
Comment 5 Michael Catanzaro 2015-08-23 00:13:37 UTC
(In reply to Hirotaka Maruyama from comment #4)
> Created attachment 309872 [details]
> buildlog with 3.16 latest git
> 
> Hi devs,
> 
> This patch seems to fail to build with the latest 3.16 git codebase?

It requires WebKitGTK+ 2.9.5; that's probably what you're missing.

I don't think there's any really good reason to backport this, though... in theory, it shouldn't change the user experience; it just means switching from one set of bugs to another.
Comment 6 Michael Catanzaro 2015-08-23 00:17:25 UTC
Ah, I guess you really want the patch in bug #753092 that adds the useful hidden option, and just included this patch as well since it's related. Both patches require WebKitGTK+ 2.9.5.
Comment 7 Hirotaka Maruyama 2015-08-23 00:29:50 UTC
Dear Michael Catanzaro,

Yep all I want is that patch in #753092. So I'll try to rebuild with WebKitGTK+ 2.9.5...

Thanks! :)

Best Regards.