Created attachment 308481 [details] [review]
spinner: use a 60fps spinner

- sync with gtk+ and provide a fluid spinner

Review of attachment 308481 [details] [review]:

::: js/gdm/authPrompt.js
@@ +18,2 @@
 const DEFAULT_BUTTON_WELL_ANIMATION_DELAY = 1.0;
+const DEFAULT_BUTTON_WELL_ANIMATION_TIME = 0.04;

Just to make sure: this is the time used to fade out the spinner when stopping the animation (i.e. it is not related to the spinner animation itself). Is this intentional?
(Same applies for all the other ANIMATION_TIME constants)

::: js/ui/status/network.js
@@ +879,2 @@
         let file = Gio.File.new_for_uri('resource:///org/gnome/shell/theme/process-working.svg');
+        this._noNetworksSpinner = new Animation.AnimatedIcon(file, 16, 16);

Have you tried this? This is the one place where I'm not convinced the smaller icon works as well as the previous size ...

(In reply to Florian Müllner from comment #2)
> Review of attachment 308481 [details] [review] [review]:
> 
> ::: js/gdm/authPrompt.js
> @@ +18,2 @@
>  const DEFAULT_BUTTON_WELL_ANIMATION_DELAY = 1.0;
> +const DEFAULT_BUTTON_WELL_ANIMATION_TIME = 0.04;
> 
> Just to make sure: this is the time used to fade out the spinner when
> stopping the animation (i.e. it is not related to the spinner animation
> itself). Is this intentional?

Nope, not intentional.

> ::: js/ui/status/network.js
> @@ +879,2 @@
>          let file =
> Gio.File.new_for_uri('resource:///org/gnome/shell/theme/process-working.
> svg');
> +        this._noNetworksSpinner = new Animation.AnimatedIcon(file, 16, 16);
> 
> Have you tried this? This is the one place where I'm not convinced the
> smaller icon works as well as the previous size ...

Can we avoid having multiple sizes of the sprite? Especially when it's vectors...

Created attachment 308530 [details] [review]
spinner: use a 60fps spinner

- sync with gtk+ and provide a fluid spinner

*** Bug 753277 has been marked as a duplicate of this bug. ***

The spinner in the network panel is indeed on the small size, but it's workable from my POV. We can revisit (going 24x24 for the panel might be viable).

Attachment 308530 [details] pushed as 27a7194 - spinner: use a 60fps spinner