After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753055 - window-list: Don't consider skip-taskbar windows for app sorting
window-list: Don't consider skip-taskbar windows for app sorting
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-07-30 13:34 UTC by Florian Müllner
Modified: 2015-07-30 16:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window-list: Don't consider skip-taskbar windows for app sorting (1.18 KB, patch)
2015-07-30 13:34 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2015-07-30 13:34:22 UTC 
See patch.
Comment 1 Florian Müllner 2015-07-30 13:34:31 UTC 
Created attachment 308459 [details] [review]
window-list: Don't consider skip-taskbar windows for app sorting

It is odd to consider windows that are not shown in the window list
for app sorting, in particular when switching between grouped and
ungrouped mode, and when a long-lived window like the DESKTOP is
present.
Comment 2 Rui Matos 2015-07-30 13:53:12 UTC 
Review of attachment 308459 [details] [review]:

Should we use the same logic as BaseButton._isWindowVisible() ?
Comment 3 Florian Müllner 2015-07-30 15:16:38 UTC 
No - like windows, apps should appear in the order they were launched. Skip-taskbar windows don't affect the app's running state, so excluding them makes sense. However I don't think we want the order to depend on "random" stuff like which workspace was active when the extension was enabled or the grouping-mode setting was changed.
Comment 4 Rui Matos 2015-07-30 16:04:41 UTC 
Review of attachment 308459 [details] [review]:

(In reply to Florian Müllner from comment #3)
> No - like windows, apps should appear in the order they were launched.
> Skip-taskbar windows don't affect the app's running state, so excluding them
> makes sense. However I don't think we want the order to depend on "random"
> stuff like which workspace was active when the extension was enabled or the
> grouping-mode setting was changed.

makes sense
Comment 5 Florian Müllner 2015-07-30 16:25:22 UTC 
Attachment 308459 [details] pushed as 6062284 - window-list: Don't consider skip-taskbar windows for app sorting