GNOME Bugzilla – Bug 752980
enterprise login fixes
Last modified: 2015-07-31 19:32:13 UTC
Here's a few fixes that get enterprise login working again.
Created attachment 308322 [details] [review] keyring: don't change keyring password explicitly It will happen automatically by the pam stack
Created attachment 308323 [details] [review] password: detect enterprise account by NULL username when saving Right now we detect an enterprise account by the lack of an ActUser object. That can't work going forward though, since other bits of the code need an ActUser object for enterprise accounts. This commit changes the heuristic to look for a NULL username.
Created attachment 308324 [details] [review] account: set act_user object on driver The summary page expects the act-user object to be set in the driver. That only happens at the moment for local users, not enterprise login users. This commit fixes things, so it happens for enterprise login users as well.
Created attachment 308325 [details] [review] driver: duplicate password Otherwise it will get freed at an inopportune moment.
Review of attachment 308322 [details] [review]: given that you've tested it with local and enterprise accounts, +1
Review of attachment 308323 [details] [review]: hmm, ok. So we replace one heuristic with another... could just add an explicit getter/setter to the driver
Review of attachment 308324 [details] [review]: ok
Review of attachment 308325 [details] [review]: ::: gnome-initial-setup/gis-driver.c @@ +181,3 @@ { GisDriverPrivate *priv = gis_driver_get_instance_private (driver); priv->user_account = user; Shouldn't we then go all the way and ref the user as well ?
Created attachment 308580 [details] [review] password: detect enterprise account without heuristic Right now we detect an enterprise account by the lack of an ActUser object. That can't work going forward though, since other bits of the code need an ActUser object for enterprise accounts. This commit adds the account mode to the driver and changes the password page to look at the account mode directly.
Created attachment 308581 [details] [review] driver: duplicate password/user object The driver needs to hold an internal copy of the password, so the password isn't freed at an inopportune moment. For symmetry, this commit also takes a reference on the user object that is passed at the same time.
pushed with suggested improvements Attachment 308322 [details] pushed as 0216872 - keyring: don't change keyring password explicitly Attachment 308324 [details] pushed as 857e22c - account: set act_user object on driver Attachment 308580 [details] pushed as 9d5b92e - password: detect enterprise account without heuristic Attachment 308581 [details] pushed as 2842336 - driver: duplicate password/user object