GNOME Bugzilla – Bug 752968
[HighContrast] no difference between connected and non-connected people
Last modified: 2015-07-30 14:53:53 UTC
When using the HighContrast theme, there’s no difference between connected and non-connected people in the main textview; using Adwaita, connected people nicks are written blue and non-connected one grey.
Mmh, yeah - the connected nick color is picked up from the theme, and we simply desaturate it for disconnected nicks. That's obviously an issue if the original color was already grayscale (or, I suppose, for certain kinds of color-blindness). Maybe we should make connected nicks bold?
I’d choose italic for non-connected people, as bold usually takes too much importance in the view.
Created attachment 308326 [details] [review] chatView: Use italic style for inactive nicks Commit c96929c701 introduced different styling for active and inactive nicks. However simply desaturating the theme's link color will not result in a different color if the original color was already a shade of gray; also, relying solely on color can be problematic in other cases like color blindness as well. To address this, differentiate active and inactive nicks by font style as well as color. This implements the suggestion from comment #2, though I'm not sure I like the result - let's try to get some design feedback first before committing anything.
Created attachment 308331 [details] stroke offline names (In reply to Florian Müllner from comment #3) > This implements the suggestion from comment #2, though I'm not sure I like > the result - let's try to get some design feedback first before committing > anything. How about stroking the names? Something stroked better conveys the meaning of being "unavailable" too, even in high contrast mode. (attachment is a quick mockup)
Created attachment 308337 [details] [review] chatView: Don't mingle separating whitespace with nick We get away with piggy-backing the '\t' character that separates nick and message with the former as long as the style we apply to the nick doesn't affect whitespace - this is about to change, so insert the whitespace separately.
Created attachment 308338 [details] [review] chatView: Strike through inactive nicks Commit c96929c701 introduced different styling for active and inactive nicks. However simply desaturating the theme's link color will not result in a different color if the original color was already a shade of gray; also, relying solely on color can be problematic in other cases like color blindness as well. To address this, differentiate active and inactive nicks as well by striking through inactive nicks.
(In reply to Bastian Ilsø from comment #4) > How about stroking the names? Readability suffers a bit, but worth a try ...
Created attachment 308465 [details] [review] chatView: Make sure active and inactive nicks use distinct colors We came up with yet another option on IRC :-)
(In reply to Florian Müllner from comment #8) > Created attachment 308465 [details] [review] [review] > chatView: Make sure active and inactive nicks use distinct colors > > We came up with yet another option on IRC :-) LGTM? (-8
OK, let's go with the last option. Attachment 308465 [details] pushed as 0df771d - chatView: Make sure active and inactive nicks use distinct colors