After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752900 - Return value error in tracker_file_notifier_get_file_type
Return value error in tracker_file_notifier_get_file_type
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: Miners
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: tracker-general
tracker-general
Depends on:
Blocks:
 
 
Reported: 2015-07-26 17:18 UTC by Ting-Wei Lan
Modified: 2015-07-31 15:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Fix return value error for tracker_file_notifier_get_file_type (1.10 KB, patch)
2015-07-26 17:18 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2015-07-26 17:18:11 UTC 
These errors showed when compiling tracker with clang:

tracker-file-notifier.c:1770:2: error: non-void function 'tracker_file_notifier_get_file_type' should return a value [-Wreturn-type]
        g_return_if_fail (TRACKER_IS_FILE_NOTIFIER (notifier));
        ^
/home/lantw44/gnome/devinstall/include/glib-2.0/glib/gmessages.h:379:3: note: expanded from macro 'g_return_if_fail'
         return;                                                        \
         ^
tracker-file-notifier.c:1771:2: error: non-void function 'tracker_file_notifier_get_file_type' should return a value [-Wreturn-type]
        g_return_if_fail (G_IS_FILE (file));
        ^
/home/lantw44/gnome/devinstall/include/glib-2.0/glib/gmessages.h:379:3: note: expanded from macro 'g_return_if_fail'
         return;                                                        \
         ^
1 warning and 2 errors generated.
Comment 1 Ting-Wei Lan 2015-07-26 17:18:55 UTC 
Created attachment 308182 [details] [review]
build: Fix return value error for tracker_file_notifier_get_file_type
Comment 2 Martyn Russell 2015-07-31 14:17:08 UTC 
Comment on attachment 308182 [details] [review]
build: Fix return value error for tracker_file_notifier_get_file_type

Patch looks good, thanks for noticing! :)
Comment 3 Ting-Wei Lan 2015-07-31 15:06:23 UTC 
Attachment 308182 [details] pushed as 789462f - build: Fix return value error for tracker_file_notifier_get_file_type