After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752831 - datetime: Load backward file from GResource
datetime: Load backward file from GResource
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-24 14:44 UTC by Bastien Nocera
Modified: 2015-07-26 21:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
datetime: Load backward file from GResource (3.14 KB, patch)
2015-07-24 14:44 UTC, Bastien Nocera
none Details | Review
datetime: Load backward file from GResource (3.49 KB, patch)
2015-07-24 15:40 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2015-07-24 14:44:35 UTC
.
Comment 1 Bastien Nocera 2015-07-24 14:44:39 UTC
Created attachment 308083 [details] [review]
datetime: Load backward file from GResource

So it doesn't warn when not installed in the target prefix yet.
Comment 2 Rui Matos 2015-07-24 15:21:18 UTC
Review of attachment 308083 [details] [review]:

otherwise looks fine

::: panels/datetime/Makefile.am
@@ +33,3 @@
 test_timezone_CFLAGS = $(DATETIME_PANEL_CFLAGS)
 
+test_timezone_gfx_SOURCES = test-timezone-gfx.c tz.c tz.h cc-datetime-resources.c cc-datetime-resources.h

we should also stop installing the backward file in tzdatadir. just move backward to EXTRA_DIST ?
Comment 3 Bastien Nocera 2015-07-24 15:40:58 UTC
Created attachment 308089 [details] [review]
datetime: Load backward file from GResource

So it doesn't warn when not installed in the target prefix yet.
Comment 4 Bastien Nocera 2015-07-24 15:41:35 UTC
(In reply to Rui Matos from comment #2)
> Review of attachment 308083 [details] [review] [review]:
> 
> otherwise looks fine
> 
> ::: panels/datetime/Makefile.am
> @@ +33,3 @@
>  test_timezone_CFLAGS = $(DATETIME_PANEL_CFLAGS)
>  
> +test_timezone_gfx_SOURCES = test-timezone-gfx.c tz.c tz.h
> cc-datetime-resources.c cc-datetime-resources.h
> 
> we should also stop installing the backward file in tzdatadir. just move
> backward to EXTRA_DIST ?

We should just not install it, it will automatically be in extra dist, as all the files referenced by the resource.xml file are.
Comment 5 Rui Matos 2015-07-24 15:54:18 UTC
Review of attachment 308089 [details] [review]:

right, ok
Comment 6 Bastien Nocera 2015-07-26 21:49:15 UTC
Attachment 308089 [details] pushed as 557dc46 - datetime: Load backward file from GResource