After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752825 - v4l2: Patch to remove limit on framerate
v4l2: Patch to remove limit on framerate
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2015-07-24 13:28 UTC by Dimitrios Katsaros
Modified: 2015-08-16 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Patch to remove limit on v4l2src framerate (2.70 KB, patch)
2015-07-24 13:28 UTC, Dimitrios Katsaros
committed Details | Review

Description Dimitrios Katsaros 2015-07-24 13:28:57 UTC
Created attachment 308079 [details] [review]
Patch to remove limit on v4l2src framerate

The current implementation of v4l2 has a hard-coded limit of 100 fps for v4l2 devices. This limits certain applications that may require an even higher framerate and it also limits cameras with hardware cropping being applied to them, which can also lead to framerates higher than 100. 

This patch remedies this issue. It first sets the maximum possible framerate to G_MAXINT/1 to ensure that any future application needing higher framerates is not capped. This patch also changes the default framerate so it is set to 100, as it would be for all applications that do not set a framerate before this patch.
Comment 1 Nicolas Dufresne (ndufresne) 2015-07-24 22:54:26 UTC
Review of attachment 308079 [details] [review]:

Indeed, this limit was totally arbitrary. Keeping it in the fixate function is probably a good idea for the default case. So I think this patch should go in.
Comment 2 Nicolas Dufresne (ndufresne) 2015-07-25 14:42:10 UTC
Comment on attachment 308079 [details] [review]
Patch to remove limit on v4l2src framerate

Thanks! Please notice the commit message format for further submissions.

Author: Dimitrios Katsaros <>
Date:   Fri Jul 24 15:10:05 2015 +0200

    v4l2: Allow framerate to be large then 100pfs
    This limit was arbitrary. We still fixate near 100pfs for compatibility.
Comment 3 Dimitrios Katsaros 2015-07-27 06:54:47 UTC
Duly noted, I will keep the commit format in mind in the future. Thanks for the quick response!