Created attachment 307926 [details] [review]
authPrompt: set next button to next when asking for username

If the next button ever gets set to Sign In, it won't
get reset to next until the next question asked by pam.

This commit ensures it gets reset to Next when asking
for the username.

Created attachment 307927 [details] [review]
authPrompt: don't allow next if entry is empty

Normally the user isn't allowed to proceed passed
the username question until they've filled it in.
To ensure this, the authprompt code desensitizes
the next button when the number of characters change to
zero.

Unfortunately it fails to desensitize the next button
up front when the entry starts out empty.

This commit addresses that bug.

Review of attachment 307926 [details] [review]:

looks fine

Review of attachment 307927 [details] [review]:

::: js/gdm/authPrompt.js
@@ +403,2 @@
     updateSensitivity: function(sensitive) {
+        this._updateNextButtonSensitivity(this._entry.text.length > 0);

actually this should be sensitive && this._entry.text.length > 0 I guess

Review of attachment 307927 [details] [review]:

I noticed another bug here: when prompting for the user name (after clicking "Not listed?") the cancel button doesn't do anything.

::: js/gdm/authPrompt.js
@@ +403,2 @@
     updateSensitivity: function(sensitive) {
+        this._updateNextButtonSensitivity(this._entry.text.length > 0);

Shouldn't this be (sensitive && length > 0) ? i.e. even if there's text in the entry, it seems that the calling code really intends to set this button insensitive when doing those async queries.

(In reply to Rui Matos from comment #5)
> Review of attachment 307927 [details] [review] [review]:
> 
> I noticed another bug here: when prompting for the user name (after clicking
> "Not listed?") the cancel button doesn't do anything.
Oh right I fixed that in RHEL too, will post patch.

Created attachment 308014 [details] [review]
authPrompt: don't allow next if entry is empty

Normally the user isn't allowed to proceed passed
the username question until they've filled it in.
To ensure this, the authprompt code desensitizes
the next button when the number of characters change to
zero.

Unfortunately it fails to desensitize the next button
up front when the entry starts out empty.

This commit addresses that bug.

Created attachment 308015 [details] [review]
authPrompt: allow cancellation before verification starts

The user should be allowed to cancel if verification hasn't
started yet and they're typing in their username. This
commit changes the authPrompt cancel function to not
ignore such requests.

Review of attachment 308014 [details] [review]:

++

Review of attachment 308015 [details] [review]:

looks good

Attachment 307926 [details] pushed as 378a3df - authPrompt: set next button to next when asking for username
Attachment 308014 [details] pushed as fe7dd13 - authPrompt: don't allow next if entry is empty
Attachment 308015 [details] pushed as 778ad49 - authPrompt: allow cancellation before verification starts

*** Bug 753004 has been marked as a duplicate of this bug. ***

*** Bug 747395 has been marked as a duplicate of this bug. ***

note these fixes introduced bug 753181 so distros back porting this should include fixes from that bug as well.