GNOME Bugzilla – Bug 752705
rtpbuffer: Add map flag to skip padding
Last modified: 2015-10-20 09:11:37 UTC
Encrypted RTP buffers may contain encrypted padding, hence it's necessary to have an option to relax the validation in order to successfully map the buffer. When the flag GST_RTP_BUFFER_MAP_FLAG_SKIP_PADDING is set gst_rtp_buffer_map() will map the buffer like if padding is not present.
Created attachment 307901 [details] [review] rtpbuffer: Add map flag to skip padding
Shouldn't it successfully map in any case if the only problem is some padding?
Review of attachment 307901 [details] [review]: ::: gst-libs/gst/rtp/gstrtpbuffer.h @@ +160,3 @@ + * Additional mapping flags for gst_rtp_buffer_map(). + * + * Since: 1.6 Since: 1.8
Not completely sure what you have in mind? The check of padding is one of the few possible validity checks (RFC3550 A.1) and it's probably not a good idea to always silently ignore this if it fails. However, the principle of being liberal in what is accepted is usually a good guideline, so maybe it would be a better default to silently ignore padding errors unless asked to explicitly check it (e.g. with a map flag used where padding is of importance). That will of course change the validity check that's been around since 0.10. For now I'll update the patch with a new docstring.
Created attachment 313212 [details] [review] rtpbuffer: Add map flag to skip padding Encrypted RTP buffers may contain encrypted padding, hence it's necessary to have an option to relax the validation in order to successfully map the buffer. When the flag GST_RTP_BUFFER_MAP_FLAG_SKIP_PADDING is set gst_rtp_buffer_map() will map the buffer like if padding is not present.
Comment on attachment 313212 [details] [review] rtpbuffer: Add map flag to skip padding commit 0a668c186626c539d102789e52da55a4c13de35a Author: Stian Selnes <stian@pexip.com> Date: Wed Jul 22 11:31:05 2015 +0200 rtpbuffer: Add map flag to skip padding Encrypted RTP buffers may contain encrypted padding, hence it's necessary to have an option to relax the validation in order to successfully map the buffer. When the flag GST_RTP_BUFFER_MAP_FLAG_SKIP_PADDING is set gst_rtp_buffer_map() will map the buffer like if padding is not present. https://bugzilla.gnome.org/show_bug.cgi?id=752705