After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752689 - proxy volume monitor: Plug a memory leak
proxy volume monitor: Plug a memory leak
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2015-07-22 00:19 UTC by Matthias Clasen
Modified: 2015-07-22 16:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proxy volume monitor: Plug a memory leak (1.28 KB, patch)
2015-07-22 00:19 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2015-07-22 00:19:37 UTC 
valgrind pointed out a leak here, ann indeed, g_mount_get_root()
is documented as transfer full, so we should unref the GFile
when we are done with it.
Comment 1 Matthias Clasen 2015-07-22 00:19:46 UTC 
Created attachment 307877 [details] [review]
proxy volume monitor: Plug a memory leak
Comment 2 Ross Lagerwall 2015-07-22 07:07:45 UTC 
Review of attachment 307877 [details] [review]:

Looks good. (small typo in commit message "ann")
Comment 3 Matthias Clasen 2015-07-22 16:08:11 UTC 
Attachment 307877 [details] pushed as d89a848 - proxy volume monitor: Plug a memory leak