After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752675 - Update GVC to the latest version from master
Update GVC to the latest version from master
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-07-21 15:10 UTC by Mario Sánchez Prada
Modified: 2015-07-21 16:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch proposal (717 bytes, patch)
2015-07-21 15:13 UTC, Mario Sánchez Prada
accepted-commit_now Details | Review

Description Mario Sánchez Prada 2015-07-21 15:10:48 UTC
The version of GVC used by GSD is missing the latest commit upstream that fixes a problem in gnome-control-center related to duplicated output devices showing up in GCC's sound panel(see [1]), which in principle is not needed for the shell.

However, I found locally that that fix actually makes a difference in the shell as well when connecting a Bluetooth device from the shell's top panel, in that an unnecessary call to match_card_port_with_existing_device() is being executed due to the (card_port->available != info->ports[i]->available) condition being not good enough, as it does not take UNKNOWN availability into account.

So, as this is a small change anyway (only this commit was missing from shell's gvc submodule), I'm proposing to update it there too in the same way it was done already for the other modules bundling GVC (g-s-d and g-c-c).

[1] https://git.gnome.org/browse/libgnome-volume-control/commit/?id=fac3a900e5de2c60d667c54f2727e806d29cff4b
Comment 1 Mario Sánchez Prada 2015-07-21 15:13:01 UTC
Created attachment 307837 [details] [review]
Patch proposal

Updated to the latest commit from GVC
Comment 2 Jasper St. Pierre (not reading bugmail) 2015-07-21 15:43:49 UTC
Review of attachment 307837 [details] [review]:

Go for it.
Comment 3 Mario Sánchez Prada 2015-07-21 16:05:46 UTC
Thanks, fixed on master:

https://git.gnome.org/browse/gnome-shell/commit/?id=9b69a45eee75a0b8dce6fd7dd35efaf6739b4de5