GNOME Bugzilla – Bug 752669
rtpsession: Expose RTPSource stats through stats property
Last modified: 2015-10-11 09:57:51 UTC
We did it using a GValueArray for each GstStructure with RTPSource stats, to make it more python-binding friendly. https://github.com/pexip/gst-plugins-good/commit/e66a7a641c1b54146e5ac56228d66f934ab48355.patch
Created attachment 312011 [details] [review] in patch form
Review of attachment 312011 [details] [review]: Looks good except for cosmetic changes ::: gst/rtpmanager/gstrtpsession.c @@ +674,2 @@ * + * Since: 1.6 The "Since: 1.6" should only be at the "source-stats" field ::: gst/rtpmanager/rtpsession.c @@ +497,2 @@ * + * Since: 1.6 Same here
Created attachment 312111 [details] [review] rtpmanager: Add 'source-stats' to stats and notify Add statitics from each rtp source to the rtp session property. 'source-stats' is a GValueArray where each element is a GstStructure of stats for one rtp source. The availability of new stats is signaled via g_object_notify.
Created attachment 312112 [details] [review] rtpmanager: Add 'source-stats' to stats and notify Add statitics from each rtp source to the rtp session property. 'source-stats' is a GValueArray where each element is a GstStructure of stats for one rtp source. The availability of new stats is signaled via g_object_notify.
Review of attachment 312112 [details] [review]: Thanks :)
Comment on attachment 312112 [details] [review] rtpmanager: Add 'source-stats' to stats and notify Does not apply anymore, please rebase :) And make it "Since: 1.8", not 1.6.
Created attachment 312712 [details] [review] rtpmanager: Add 'source-stats' to stats and notify Add statitics from each rtp source to the rtp session property. 'source-stats' is a GValueArray where each element is a GstStructure of stats for one rtp source. The availability of new stats is signaled via g_object_notify.
Comment on attachment 312712 [details] [review] rtpmanager: Add 'source-stats' to stats and notify commit 91a78053c73baf4e34507f73715b725e3a6167b3 Author: Stian Selnes <stian@pexip.com> Date: Tue Jul 14 15:19:44 2015 +0200 rtpmanager: Add 'source-stats' to stats and notify Add statitics from each rtp source to the rtp session property. 'source-stats' is a GValueArray where each element is a GstStructure of stats for one rtp source. The availability of new stats is signaled via g_object_notify. https://bugzilla.gnome.org/show_bug.cgi?id=752669