After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752649 - COPYING states GPL-3 but GPL-2 and LGPL code present
COPYING states GPL-3 but GPL-2 and LGPL code present
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: General
unspecified
Other Linux
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-21 01:17 UTC by Robert Ancell
Modified: 2017-08-10 10:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Added copying files (1.77 KB, patch)
2017-08-08 00:40 UTC, Alex Benishek
none Details | Review
Patch which changes GPL 2 to GPL 3 (7.65 KB, patch)
2017-08-08 17:14 UTC, Alex Benishek
committed Details | Review

Description Robert Ancell 2015-07-21 01:17:02 UTC
The COPYING file states gnome-calendar is GPL-3 but the following files are marked as being GPL-2:
src/gcal-month-view.[ch]
src/gcal-search-view.[ch]
src/gcal-subscriber-view.[ch]
src/gcal-subscriber-view-private.h
src/gcal-view.[ch]
src/gcal-week-view.[ch]
src/gcal-utils.c

And these files are marked as LGPL:
src/e-cal-data-model.[ch]
src/e-cal-data-model-subscriber.[ch]

There should probably be three COPYING files, i.e. COPYING.GPL3 COPYING.GPL2 and COPYING.LGPL
Comment 1 Alex Benishek 2017-08-08 00:40:34 UTC
Created attachment 357166 [details] [review]
Added copying files

Here is the patch which adds the files as suggested if there is still any interest in fixing this bug.
Comment 2 Mohammed Sadiq 2017-08-08 03:17:30 UTC
Review of attachment 357166 [details] [review]:

Hi,

Seems like you included the wget log, and not the original license files (you should have used -O argument instead of -o)

Also, you haven't set your git name and email and so the 'From' field is set to be something strange (files < *Íú€U>) [see https://wiki.gnome.org/Newcomers/SubmitPatch ]

And after all, the original authors are still around. It may be better to re-license the files to GPLv3+ (the original authors have to decide this) wherever possible, rather than complicating the licensing terms.

Thanks
Comment 3 Georges Basile Stavracas Neto 2017-08-08 09:50:58 UTC
I hereby state that Calendar shall be moved to GPLv3. The headers of the GPLv2 files must be updated.
Comment 4 Alex Benishek 2017-08-08 17:14:12 UTC
Created attachment 357211 [details] [review]
Patch which changes GPL 2 to GPL 3

Here is a patch which changes all previously GPL2 code to GPL3
Comment 5 Georges Basile Stavracas Neto 2017-08-10 10:18:06 UTC
Thanks for your patch!