GNOME Bugzilla – Bug 752621
Added Appdata support file
Last modified: 2015-08-12 20:55:49 UTC
Created attachment 307742 [details] [review] Appdata support Added Appdata support for Network-Manager applet. This is one of GNOME goals https://wiki.gnome.org/Initiatives/GnomeGoals/AppDataGnomeSoftware for adding Appdata support files in GNOME core components. Attached is the patch to add appdata support for nm-applet package
Dear Maintainers, kindly review the patch for its correctness.
I think our preferred spellings are "NetworkManager", "nm-applet", "nm-connection-editor" or "network-manager-applet". Also, the <description> should talk more about what nm-applet is, instead it talks mainly about NetworkManager (core). How about something like: network-manager-applet is a gtk-based UI for NetworkManager. It consists of nm-applet to shows a tray icon and allows connecting to networks. Another part is nm-connection-editor which allows to create and edit existing connection profiles for NetworkManager. Also, <updatecontact>ethirajand@cdac.in</updatecontact>... shouldn't we add there some upstream email address, maybe even the upstream NM mailing list? Just some spelling issues, otherwise LGTM
There's also some confusion here between nm-applet and nm-connection-editor. I think appdata is mostly useful for nm-connection-editor since that's a user-runnable program. Not so much for nm-applet because that's supposed to be launched on session startup and without any user action. AFAIUI appdata is mostly used for GNOME Software center and distro package managers, so I think it's more appropriate to have the appdata stuff be about nm-connection-editor.
Hi all, Thanks for the review comments.. As Dan said..the nm-connection-editor is the user-runnable program and that needs to be listed in any software center. Thomas.. as you have mentioned i have corrected the description properly to match the nm-connection-editor and mentioned on nm-applet as well. For the contact i have updated with gnome bugs team. I have attached the updated patch..kindly review the same..
Created attachment 308697 [details] [review] Appdata support - updated patch Corrected for description and email abt nm-connection-editor
(In reply to Ethirajan D from comment #5) > Created attachment 308697 [details] [review] [review] > Appdata support - updated patch > > Corrected for description and email abt nm-connection-editor The wording still sounds a bit strange to me, but I don't have concrete suggestions. Therefore: LGTM.
I changed the wording a bit to better conform to how we describe NM. Hope that's OK. Thanks! pushed to git master (80937b6339a47b98c51fcad1b30ab66b1cfe2be5) and nma-1-0 (1885cf15d1089fc044309197b55563825be14bdb)