After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752554 - "Set as Wallpaper" makes pointless copies in the same directory
"Set as Wallpaper" makes pointless copies in the same directory
Status: RESOLVED DUPLICATE of bug 688812
Product: nautilus
Classification: Core
Component: general
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-18 07:48 UTC by Kenneth Graunke
Modified: 2016-04-02 09:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (3.08 KB, patch)
2016-03-31 20:00 UTC, Ernestas Kulik
none Details | Review

Description Kenneth Graunke 2015-07-18 07:48:13 UTC
I tried to use Nautilus (3.16.1, Arch Linux) to set ~/.backgrounds/foobar.jpg as my desktop wallpaper.  First, I navigated to ~/.backgrounds, then I right clicked on foobar.jpg and hit "Set as Wallpaper".

Surprisingly, this creates a copy in the *same* directory:

    ~/.backgrounds/foobar (copy).jpg

and sets *that* as the wallpaper.  Nothing ever cleans up these files, so it ends up littering my filesystem with pointless copies every time I change background images.

I understand the need to make a copy if the file is on removable media, but this directory is on my permanently-attached /home partition, so it shouldn't need to copy it at all.  It should just use the original image.  Or, make a copy somewhere in ~/.gnome that doesn't clutter up the original location...
Comment 1 Carlos Soriano 2015-07-29 13:11:27 UTC
Definitely we have to improve this...
Comment 2 Peter Wunder 2016-03-07 22:08:33 UTC
It's been over 6 months now. Has anything happened in regards to this?
Comment 3 Carlos Soriano 2016-03-08 08:39:30 UTC
(In reply to Peter Wunder from comment #2)
> It's been over 6 months now. Has anything happened in regards to this?

If the bug is not marked as fixed, usually means that no progress. This is the bug to track this change or any patch that contributors may provide.
Comment 4 Ernestas Kulik 2016-03-31 20:00:44 UTC
Created attachment 325113 [details] [review]
Proposed patch

I wasn’t sure how to go about this, but URI string comparison seemed to be the simplest way.
Comment 5 Carlos Soriano 2016-04-02 09:44:29 UTC
This is a duplicate. There we have a discussion about it.

*** This bug has been marked as a duplicate of bug 688812 ***