After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752502 - Documentation fix for GdkGLContext
Documentation fix for GdkGLContext
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Documentation
unspecified
Other Linux
: Normal minor
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-07-16 16:09 UTC by Daniel Hams
Modified: 2015-07-19 18:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Change property description from GdkWindow to GdkDisplay (709 bytes, patch)
2015-07-16 16:09 UTC, Daniel Hams 		none Details | Review
GdkGLContext little fix to property names and descriptions (1.57 KB, patch)
2015-07-16 16:24 UTC, Daniel Hams 		committed Details | Review

Description Daniel Hams 2015-07-16 16:09:27 UTC 
Created attachment 307573 [details] [review]
Change property description from GdkWindow to GdkDisplay

A little error in the documentation in gdk/gdkglcontext.c
Comment 1 Emmanuele Bassi (:ebassi) 2015-07-16 16:18:27 UTC 
Review of attachment 307573 [details] [review]:

Thanks for the patch!

::: gdk/gdkglcontext.c
@@ +256,3 @@
    * GdkGLContext:display:
    *
+   * The #GdkDisplay the gl context is from.

The wording is a bit awkward — it was awkward in the beginning, so it's really my fault.

I'd rewrite it as:

  The #GdkDisplay used to create the #GdkGLContext.
Comment 2 Daniel Hams 2015-07-16 16:24:50 UTC 
Created attachment 307574 [details] [review]
GdkGLContext little fix to property names and descriptions

Changed as suggested + did a quick pass on the other properties there too.
Comment 3 Emmanuele Bassi (:ebassi) 2015-07-16 16:35:04 UTC 
Review of attachment 307574 [details] [review]:

Looks good, thanks!