After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752462 - multifilesrc: set position as offset from start-index
multifilesrc: set position as offset from start-index
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal minor
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-16 04:08 UTC by Prashant Gotarne
Modified: 2016-05-27 19:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
multifilesrc: set position as offset from start-index (1.06 KB, patch)
2015-07-16 04:10 UTC, Prashant Gotarne 		committed Details | Review

Description Prashant Gotarne 2015-07-16 04:08:14 UTC 
query position in GST_FORMAT_BUFFER should returns 
offset from start-index rather than index.
Comment 1 Prashant Gotarne 2015-07-16 04:10:09 UTC 
Created attachment 307525 [details] [review]
multifilesrc: set position as offset from start-index

query position in GST_FORMAT_BUFFER returns 
offset from start-index rather than index
Comment 2 Tim-Philipp Müller 2016-05-27 19:35:08 UTC 
Thanks, I think that makes sense. I changed it to set the format that was requested though instead of replacing it:

commit 4bdd192fb342bee9394bc4013b9fc563dc035649
Author: Prashant Gotarne <ps.gotarne@samsung.com>
Date:   Thu Jul 16 09:48:46 2015 +0530

    multifilesrc: set position as offset from start-index
    
    query position in GST_FORMAT_BUFFER returns
    offset from start-index rather than index.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=752462



(Also, there's no locking anywhere there - but that's nothing to do with your patch of course :))
Comment 3 Tim-Philipp Müller 2016-05-27 19:35:57 UTC 
Oh, I missed that the original code always set GST_FORMAT_BUFFERS as well, sorry :)