GNOME Bugzilla – Bug 752461
validate:launcher: skip default assets for --medias-paths
Last modified: 2015-08-16 13:36:59 UTC
When --medias-paths is set as run tests for media present in the path, it runs test cases on default test media as well. Added a property skip_default, by which only the media present in the path specified will be tested This can be used like gst-validate-launcher --medias-paths /path/to/media/files --generate-media-info --skip-default I couldn't find any way to do this, if already present.
Created attachment 307524 [details] [review] add skip-default paths property
Review of attachment 307524 [details] [review]: Actually we should probably not run tests on default assets if the user sepcifies --media-paths (and he has to explicitely provide the default path if he want it). Can you provide a patch?
Even i wanted to do like that only.. when medias-paths is being set self.paths is being populated.. so probably in add_path, we can check if self.paths is already available and return.. But i was a little skeptical if this is proper, so i thought of adding a new property.. you think checking self.paths and returning is ok?
(In reply to Vineeth from comment #3) > Even i wanted to do like that only.. > when medias-paths is being set self.paths is being populated.. > so probably in add_path, we can check if self.paths is already available and > return.. > > But i was a little skeptical if this is proper, so i thought of adding a new > property.. > you think checking self.paths and returning is ok? Not sure where, but yes, something like that.
Created attachment 307534 [details] [review] skip default assets for --media-paths option
Review of attachment 307534 [details] [review]: ::: validate/launcher/main.py @@ -295,3 +295,3 @@ self.http_server_dir = path def add_paths(self, paths): You should add a Force=False option that would bypass that behaviour. That way the testsuite can force the behaviour.
Created attachment 307545 [details] [review] skip default assets for --media-paths option added --force-default-dir option to let testsuite force usage of default media directories
Review of attachment 307545 [details] [review]: ::: validate/launcher/main.py @@ +429,3 @@ dir_group.add_argument("-p", "--medias-paths", dest="paths", action="append", help="Paths in which to look for media files") + dir_group.add_argument("-for", "--force-default-dir", dest="force", action="store_true", I did not mean that, I meant an argument in the add_paths method with a default value=False
Created attachment 307549 [details] [review] skip default assets for --media-paths option added a Force argument to add_paths This needs change in gst-integration-testsuites as well. Updating the same in the next patch.
Created attachment 307550 [details] [review] Force argument added to add_paths. Default value is set as False. It should be set to True, when default media directories should be used.
Review of attachment 307549 [details] [review]: ::: validate/launcher/main.py @@ -295,3 +295,3 @@ self.http_server_dir = path - def add_paths(self, paths): + def add_paths(self, paths, Force): You should set the default value of Force here: def add_paths(self, paths, force=False):
Review of attachment 307550 [details] [review]: Not needed.
Created attachment 307551 [details] [review] skip default assets for --media-paths option :) please check if this is fine..
Review of attachment 307551 [details] [review]: Good