After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752422 - direct messages don't show until you click the notification
direct messages don't show until you click the notification
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
3.17.x
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-15 13:53 UTC by Jakub Steiner
Modified: 2015-07-21 00:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
data: Renumber filters in client file (1.28 KB, patch)
2015-07-21 00:06 UTC, Florian Müllner
committed Details | Review
data: Add observer interface and filters to client file (2.26 KB, patch)
2015-07-21 00:06 UTC, Florian Müllner
committed Details | Review

Description Jakub Steiner 2015-07-15 13:53:44 UTC
Currently when someone initiates a direct query to you, you don't see this in the channel sidebar until you actually activate the system notification. I think polari should expose these in the sidebar straight away and only activate/select one when you click the notification. They shouldn't remain hidden and rely on you going to the system popover.
Comment 1 Florian Müllner 2015-07-21 00:06:46 UTC
Created attachment 307788 [details] [review]
data: Renumber filters in client file

Since commit 0b27b1347 removed the first handler filter, we no longer
start counting from 0 as the hacker gods demand - rectify this.
Comment 2 Florian Müllner 2015-07-21 00:06:52 UTC
Created attachment 307789 [details] [review]
data: Add observer interface and filters to client file

When a telepathy client appears on the bus, mission-control will only use the
interface information exposed on the bus for the proxy object if it cannot
locate a .client file matching the client's bus name[0]. As we do not set
TpBaseClient:uniquify-name, our bus name does match the .client file added
in commit 21df75d20 and the interface information from the file will be used
instead.
However our .client file currently only announces the Handler interface, so
mission-control doesn't consider us an observer anymore - add appropriate
information for the Observer interface to fix that regression.

[0] http://cgit.freedesktop.org/telepathy/telepathy-mission-control/tree/src/mcd-client.c#n899
Comment 3 Florian Müllner 2015-07-21 00:07:38 UTC
Attachment 307788 [details] pushed as d656ee4 - data: Renumber filters in client file
Attachment 307789 [details] pushed as 49ffd75 - data: Add observer interface and filters to client file