GNOME Bugzilla – Bug 752417
Failure to create storage pool
Last modified: 2016-09-20 08:15:55 UTC
Seems the patch we applied for bug#668536, now causes problems with newer (don't know when this changed) libvirt: libvirt bails out on building the pool if underlying directory already exists.
Created attachment 307472 [details] [review] vm-configurator: Don't create pool directory Seems latest libvirt errors out on building the storage pool building if underlying directory already exists. This patch basically reverts commit c2a77d21, which we shouldn't need anymore any way since we have code that handles the situation of user moving or removing the directory in VMCreator.get_storage_pool().
Created attachment 307473 [details] [review] vm-configurator: Don't create pool directory Seems latest libvirt errors out on building the storage pool building if underlying directory already exists. This patch basically reverts commit c2a77d21, which we shouldn't need anymore any way since we have code that handles the situation of user moving or removing the directory in VMCreator.get_storage_pool().
Created attachment 307491 [details] [review] vm-creator: Make use of internal util functions Make code simpler by use of internal util function to ensure storage pool directory exists.
Created attachment 307492 [details] [review] vm-creator: Ensure images dir even if pool is active Seems it's possible for storage pool to remain active even if underlying directory is removed. Let's always ensure images directory exists.
Created attachment 307493 [details] [review] vm-configurator: Don't create pool directory Seems latest libvirt errors out on building the storage pool building if underlying directory already exists. This patch basically reverts commit c2a77d21, which we shouldn't need anymore any way since we have code that handles the situation of user moving or removing the directory in VMCreator.get_storage_pool().
Created attachment 307494 [details] [review] vm-creator: get_storage_pool() -> Util.ensure_storage_pool() Make protected function of VMCreator that ensures storage pool exists, a public utility function so other modules can use it too.
Created attachment 307495 [details] [review] util-app: Always refresh storage pool Let's make refreshing of storage pool an unconditional activity of ensure_storage_pool() utility function.
Created attachment 307496 [details] [review] libvirt-broker: Make use of ensure_storage_pool()
Attachment 307491 [details] pushed as 9320041 - vm-creator: Make use of internal util functions Attachment 307492 [details] pushed as 81075d3 - vm-creator: Ensure images dir even if pool is active Attachment 307493 [details] pushed as afb7150 - vm-configurator: Don't create pool directory Attachment 307494 [details] pushed as 9ebdcf9 - vm-creator: get_storage_pool() -> Util.ensure_storage_pool() Attachment 307495 [details] pushed as aa23403 - util-app: Always refresh storage pool Attachment 307496 [details] pushed as 5f48f07 - libvirt-broker: Make use of ensure_storage_pool()
Looks like https://www.redhat.com/archives/libvir-list/2015-July/msg00597.html