After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752408 - video-overlay-composition:use standard way of overlay composition DEFINES
video-overlay-composition:use standard way of overlay composition DEFINES
Status: RESOLVED INVALID
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-15 09:13 UTC by Sudip Jain
Modified: 2015-07-15 14:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
standard defines for overlay-compositon patch (1.50 KB, patch)
2015-07-15 09:13 UTC, Sudip Jain 		reviewed Details | Review

Description Sudip Jain 2015-07-15 09:13:11 UTC 
Created attachment 307455 [details] [review]
standard defines for overlay-compositon patch

The overlay-composition definition used are deprecated. Use the same way as for other components.

For e.g 

Remove the private cast GST_VIDEO_OVERLAY_COMPOSITION_CAST(obj) define with 
(G_TYPE_CHECK_INSTANCE_CAST ((obj), GST_TYPE_VIDEO_OVERLAY_COMPOSITION, GstVideoOverlayComposition))

BR,
Sudip
Comment 1 Tim-Philipp Müller 2015-07-15 09:36:05 UTC 
Comment on attachment 307455 [details] [review]
standard defines for overlay-compositon patch

This looks suspicious to me. Did you test these?

GstVideoOverlayComposition is a GstMiniObject not a GTypeInstance.