After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752383 - Improve input source chooser responsiveness
Improve input source chooser responsiveness
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Region & Language
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-14 17:02 UTC by Rui Matos
Modified: 2015-07-22 14:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
region: Avoid overly long labels causing horizontal scrolling (905 bytes, patch)
2015-07-14 17:02 UTC, Rui Matos 		committed Details | Review
region: Don't ever show all input sources in the chooser (6.86 KB, patch)
2015-07-14 17:02 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2015-07-14 17:02:38 UTC 
This never worked very well (sluggish response while filtering) so I
think it's time to compromise the design a bit but make it work better
at least.
Comment 1 Rui Matos 2015-07-14 17:02:43 UTC 
Created attachment 307416 [details] [review]
region: Avoid overly long labels causing horizontal scrolling

Just ellipsize them instead.
Comment 2 Rui Matos 2015-07-14 17:02:48 UTC 
Created attachment 307417 [details] [review]
region: Don't ever show all input sources in the chooser

While filtering we're adding all the input source rows to the
GtkListBox. This is a performance issue since GtkListBox doesn't
really cope with a big number of rows.

Instead, we'll filter the locale rows in a way such that we'll show a
locale row for which any input source name matches. From this filtered
locales view, users will still need to activate a locale row to get to
the input source rows view.
Comment 3 Bastien Nocera 2015-07-15 06:05:55 UTC 
Review of attachment 307416 [details] [review]:

Sure.
Comment 4 Bastien Nocera 2015-07-15 06:23:18 UTC 
Review of attachment 307417 [details] [review]:

That looks good overall, and fine code-wise, but I'd like to get buy-in from the designers.
Comment 5 Rui Matos 2015-07-15 13:49:11 UTC 
Allan, can you try this and give us your opinion?
Comment 6 Rui Matos 2015-07-15 13:51:40 UTC 
Comment on attachment 307416 [details] [review]
region: Avoid overly long labels causing horizontal scrolling

Attachment 307416 [details] pushed as f2f4626 - region: Avoid overly long labels causing horizontal scrolling
Comment 7 Allan Day 2015-07-21 17:15:17 UTC 
(In reply to Rui Matos from comment #2)
> Created attachment 307417 [details] [review] [review]
> region: Don't ever show all input sources in the chooser

Just returning locales as search results isn't as good as returning input sources. And if the number of sources is the reason for the slowness, can't we just kill some of the crazy ones that no one ever uses (pretty please)?

But sure, the change seems acceptable...
Comment 8 Rui Matos 2015-07-22 14:34:21 UTC 
(In reply to Allan Day from comment #7)
> Just returning locales as search results isn't as good as returning
> input sources. And if the number of sources is the reason for the
> slowness, can't we just kill some of the crazy ones that no one ever
> uses (pretty please)?

Right, but that's a hornets nest I don't want to stir for now...

> But sure, the change seems acceptable...

ok, thanks

Attachment 307417 [details] pushed as 66604d4 - region: Don't ever show all input sources in the chooser