After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752375 - adaptivedemux: gst_query_set_seeking could be called with invalid values
adaptivedemux: gst_query_set_seeking could be called with invalid values
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-14 14:33 UTC by Florin Apostol
Modified: 2015-10-12 10:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Florin Apostol 2015-07-14 14:33:08 UTC 
The gst_adaptive_demux_src_query function, for the GST_QUERY_SEEKING switch case will call the gst_query_set_seeking function regardless if the previous gst_adaptive_demux_get_live_seek_range has returned true or false. If gst_adaptive_demux_get_live_seek_range has returned false, then start and stop might not be valid, so gst_query_set_seeking should not be called.
Comment 1 A Ashley 2015-10-06 13:25:40 UTC 
Looking at hlsdemux and dashdemux, the implementations of get_live_seek_range only change the values of start and stop when returning TRUE.
Comment 2 Florin Apostol 2015-10-12 10:17:27 UTC 
As long as those functions promise to not change arguments when returning false (which is a reasonable assumption) it is fine.