GNOME Bugzilla – Bug 752366
ARCHIVE_FAILED error isn't handled
Last modified: 2015-08-04 08:30:34 UTC
Created attachment 307400 [details] [review] archive: Handle ARCHIVE_FAILED error Archive backend is stucked in endless loop currently e.g. if you try to mount encrypted zip file. It is caused because ARCHIVE_FAILED error is not handled, when reading data from the archive. ARCHIVE_FAILED is handled with the attached patch. The patch cause that mount job doesn't fail, just because of unknown file size, but open_for_read job fails if ARCHIVE_FAILED is returned.
It was reported downstream originally: https://bugzilla.redhat.com/show_bug.cgi?id=1242397
Review of attachment 307400 [details] [review]: ::: daemon/gvfsbackendarchive.c @@ +491,3 @@ + + if (size < 0) + g_file_info_set_size (info, size); Shouldn't this be: if (size >= 0)
Created attachment 307825 [details] [review] archive: Handle ARCHIVE_FAILED error (In reply to Ross Lagerwall from comment #2) > Review of attachment 307400 [details] [review] [review]: > > ::: daemon/gvfsbackendarchive.c > @@ +491,3 @@ > + > + if (size < 0) > + g_file_info_set_size (info, size); > > Shouldn't this be: if (size >= 0) Dammit, have to be, thanks...
Review of attachment 307825 [details] [review]: Looks good.
Comment on attachment 307825 [details] [review] archive: Handle ARCHIVE_FAILED error Thanks for review. It has been pushed to master (commit fb60a7e) and gnome-3-16 (commit c758ab5).