After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752310 - aacparse: Return proper value from gst_aac_parse_read_loas_config function
aacparse: Return proper value from gst_aac_parse_read_loas_config function
Status: RESOLVED DUPLICATE of bug 755611
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.2.4
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-13 10:38 UTC by sangkyu.choi
Modified: 2015-09-26 12:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
return proper value during check loas config (930 bytes, patch)
2015-07-13 10:39 UTC, sangkyu.choi 		none Details | Review

Description sangkyu.choi 2015-07-13 10:38:51 UTC 
in gst_aac_parse_read_loas_config function

  if (vA != 0) -> this case also return TRUE.

  because TBD.

i think that this case should return FALSE.
Comment 1 sangkyu.choi 2015-07-13 10:39:54 UTC 
Created attachment 307335 [details] [review]
return proper value during check loas config
Comment 2 sangkyu.choi 2015-07-13 10:40:38 UTC 
:Testing Performed:
1. MHEG Play live ICS streams
2. MHEG DTG test suite's streams
Comment 3 Tim-Philipp Müller 2015-09-16 13:37:50 UTC 
Thanks for the patch.

Could you provide a short sample that triggers this issue ?
Comment 4 sangkyu.choi 2015-09-16 23:38:11 UTC 
a short sample means like the test case?
right?
Comment 5 Jan Schmidt 2015-09-26 12:08:43 UTC 
Thanks for the patch - sorry it took so long to get to. Duping this to bug 755611 which has the same patch, but a couple of other minor fixes included as well.

*** This bug has been marked as a duplicate of bug 755611 ***