After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752233 - sexp: Eliminate some global variables which broke static linking
sexp: Eliminate some global variables which broke static linking
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2015-07-10 16:41 UTC by Philip Withnall
Modified: 2015-07-29 11:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sexp: Eliminate some global variables which broke static linking (2.22 KB, patch)
2015-07-10 16:41 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2015-07-10 16:41:42 UTC 
Trivial patch attached.
Comment 1 Philip Withnall 2015-07-10 16:41:45 UTC 
Created attachment 307237 [details] [review]
sexp: Eliminate some global variables which broke static linking

Compiling EDS with --disable-shared was broken due to several global
variables being declared with the same names, and not being declared
static. Fix that by eliminating the unused ones and making the rest
static.
Comment 2 Milan Crha 2015-07-14 15:52:05 UTC 
Review of attachment 307237 [details] [review]:

Looks fine, please commit to master. If you wish, then you can do gnome-3-16 as well. Please see the notation how the commit logs look like in the evolution(-data-server) before committing and use it too (mainly the first line, should be "Bug 752233 - ....").
Comment 3 Philip Withnall 2015-07-29 11:14:05 UTC 
Comment on attachment 307237 [details] [review]
sexp: Eliminate some global variables which broke static linking

Committed to master with a modified commit message.
Comment 4 Philip Withnall 2015-07-29 11:14:50 UTC 
Committed to gnome-3-16 as well.