GNOME Bugzilla – Bug 752232
Missing dependency for libgmodule in build file
Last modified: 2018-05-24 17:56:52 UTC
Created attachment 307236 [details] [review] patch for adding missing dependencies I am a researcher from the Software Analysis and Intelligence Lab (SAIL) from Queen's University in Kingston, Canada. Currently, we are working on an approach for finding missing dependencies in build files and we are using glib as a case study. We have found several bugs which I will submit in the following days, together with a patch for fixing them. The targets: glib_compile_resources, gsettings, gdbus, gapplication, gresource are linking libgmodule-2.0.la but do not compile it. Hence they may be using old versions of libgmodule-2.0.la. As can be found in the make output for gresource: /bin/bash ../libtool --tag=CC --mode=link gcc -Wall -Wstrict-prototypes -Werror=declaration-after-statement -Werror=missing-prototypes -Werror=implicit-function-declaration -Werror=pointer-arith -Werror=init-self -Werror=format-security -Werror=format=2 -Werror=missing-include-dirs -g -O2 -o gresource gresource-gresource-tool.o libgio-2.0.la ../gobject/libgobject-2.0.la ../glib/libglib-2.0.la libtool: link: gcc -Wall -Wstrict-prototypes -Werror=declaration-after-statement -Werror=missing-prototypes -Werror=implicit-function-declaration -Werror=pointer-arith -Werror=init-self -Werror=format-security -Werror=format=2 -Werror=missing-include-dirs -g -O2 -o .libs/gresource gresource-gresource-tool.o ./.libs/libgio-2.0.so /home/shane/src/glib/repo/gobject/.libs/libgobject-2.0.so /home/shane/src/glib/repo/gmodule/.libs/libgmodule-2.0.so -ldl -lz -lresolv ../gobject/.libs/libgobject-2.0.so /home/shane/src/glib/repo/glib/.libs/libglib-2.0.so -lffi ../glib/.libs/libglib-2.0.so -lpthread -lrt Similar for the other mentioned targets. The included patch adds these dependencies for the latest HEAD. We observed that these dependencies are missing since at least version 2.36.0.
We have studied this further, and it appears that the dependency on libgmodule-2.0.la is missing for the libgio_2_0_la target. I have attached an updated patch for this.
Created attachment 309335 [details] [review] patch for adding missing dependencies
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/1059.